[SYCL][Driver][FPGA] Remove support for FPGA related options #16864

mdtoguchi · 2025-01-31T18:35:20Z

Removes support for any FPGA related options and any options that use FPGA specific arguments. Upon usage of any of these options, a specific error will be emitted:

clang++ -fintelfpga file.cpp
clang++: error: option '-fintelfpga' is not supported and has been removed from the compiler. Please see the compiler documentation for more details

The following options are being handled:

-fintelfpga
-fsycl-targets=spir64_fpga[-unknown-unknown]
-fsycl-link=early/image
-Xsycl-target-backend=spir64_fpga "opt"
-reuse-exe=arg
-fsycl-help=fpga

This mainly removes support of the options as specified, subsequent cleanup of driver behaviors will be done in a later change.

Due to the broad impact of these changes, all associated LIT tests have been updated/removed.

Associated issue: #16929

…ions Removes support for any FPGA related options and any options that use FPGA specific arguments. First round to double check any fallout in testing

Remove FPGA references from the user manual and update or remove tests that are using FPGA specific behaviors.

sycl/test-e2e/DeviceCodeSplit/aot-accelerator.cpp

asudarsa

LGTM except for one issue I reported. please address.

Thanks

asudarsa

sycl/test-e2e changes owned by dpcpp-tools-reviewers looks good. thanks

clang/include/clang/Basic/DiagnosticDriverKinds.td

clang/lib/Driver/Driver.cpp

mdtoguchi · 2025-02-12T14:43:39Z

@intel/dpcpp-doc-reviewers, please take a look - thanks!

mdtoguchi · 2025-02-18T22:31:13Z

Test issues are known:
#16877
#17026

mdtoguchi · 2025-02-18T22:32:39Z

@intel/llvm-gatekeepers, given the known status of the failing tests, please consider for merge.

mdtoguchi added 3 commits January 31, 2025 10:32

In Progress- [SYCL][Driver][FPGA] Remove support for FPGA related opt…

7489d8c

…ions Removes support for any FPGA related options and any options that use FPGA specific arguments. First round to double check any fallout in testing

Merge remote-tracking branch 'intel_llvm/sycl' into fpga-remove-opts

fc42795

additional test updates

1bb16a6

mdtoguchi had a problem deploying to WindowsCILock January 31, 2025 22:21 — with GitHub Actions Error

clang format

626def9

mdtoguchi had a problem deploying to WindowsCILock January 31, 2025 22:44 — with GitHub Actions Failure

mdtoguchi temporarily deployed to WindowsCILock January 31, 2025 23:22 — with GitHub Actions Inactive

mdtoguchi added 2 commits February 3, 2025 10:29

Update and remove FPGA specific testing and doc update

c915700

Remove FPGA references from the user manual and update or remove tests that are using FPGA specific behaviors.

Merge remote-tracking branch 'intel_llvm/sycl' into fpga-remove-opts

695c700

mdtoguchi temporarily deployed to WindowsCILock February 3, 2025 18:41 — with GitHub Actions Inactive

mdtoguchi had a problem deploying to WindowsCILock February 3, 2025 19:50 — with GitHub Actions Failure

Additional cleanup

7409e74

mdtoguchi temporarily deployed to WindowsCILock February 3, 2025 22:51 — with GitHub Actions Inactive

mdtoguchi temporarily deployed to WindowsCILock February 3, 2025 23:37 — with GitHub Actions Inactive

Missed update for -fsycl-link behavior

33aefd5

mdtoguchi temporarily deployed to WindowsCILock February 4, 2025 15:20 — with GitHub Actions Inactive

mdtoguchi temporarily deployed to WindowsCILock February 4, 2025 16:32 — with GitHub Actions Inactive

tests and fsycl-link update

8d39c2c

mdtoguchi temporarily deployed to WindowsCILock February 5, 2025 18:21 — with GitHub Actions Inactive

mdtoguchi had a problem deploying to WindowsCILock February 5, 2025 19:00 — with GitHub Actions Error

clang format

8bfe08d

mdtoguchi temporarily deployed to WindowsCILock February 5, 2025 19:32 — with GitHub Actions Inactive

mdtoguchi temporarily deployed to WindowsCILock February 5, 2025 20:27 — with GitHub Actions Inactive

mdtoguchi changed the title ~~In Progress- [SYCL][Driver][FPGA] Remove support for FPGA related opt…~~ [SYCL][Driver][FPGA] Remove support for FPGA related options Feb 5, 2025

mdtoguchi marked this pull request as ready for review February 5, 2025 22:07

mdtoguchi requested review from a team as code owners February 5, 2025 22:07

Merge remote-tracking branch 'intel_llvm/sycl' into fpga-remove-opts

995798c

mdtoguchi temporarily deployed to WindowsCILock February 10, 2025 15:17 — with GitHub Actions Inactive

mdtoguchi temporarily deployed to WindowsCILock February 10, 2025 16:14 — with GitHub Actions Inactive

Merge remote-tracking branch 'intel_llvm/sycl' into fpga-remove-opts

6311908

mdtoguchi had a problem deploying to WindowsCILock February 11, 2025 17:15 — with GitHub Actions Error

asudarsa reviewed Feb 11, 2025

View reviewed changes

sycl/test-e2e/DeviceCodeSplit/aot-accelerator.cpp Outdated Show resolved Hide resolved

asudarsa requested changes Feb 11, 2025

View reviewed changes

remove test

1e45bb4

mdtoguchi requested a review from asudarsa February 11, 2025 18:22

mdtoguchi temporarily deployed to WindowsCILock February 11, 2025 18:23 — with GitHub Actions Inactive

asudarsa approved these changes Feb 11, 2025

View reviewed changes

mdtoguchi temporarily deployed to WindowsCILock February 11, 2025 20:09 — with GitHub Actions Inactive

mdtoguchi requested a review from srividya-sundaram February 11, 2025 21:48

srividya-sundaram reviewed Feb 11, 2025

View reviewed changes

clang/include/clang/Basic/DiagnosticDriverKinds.td Show resolved Hide resolved

srividya-sundaram reviewed Feb 11, 2025

View reviewed changes

clang/lib/Driver/Driver.cpp Show resolved Hide resolved

srividya-sundaram reviewed Feb 11, 2025

View reviewed changes

clang/lib/Driver/Driver.cpp Show resolved Hide resolved

srividya-sundaram approved these changes Feb 12, 2025

View reviewed changes

Merge remote-tracking branch 'intel_llvm/sycl' into fpga-remove-opts

ace5745

mdtoguchi temporarily deployed to WindowsCILock February 12, 2025 14:43 — with GitHub Actions Inactive

mdtoguchi temporarily deployed to WindowsCILock February 12, 2025 15:23 — with GitHub Actions Inactive

AlexeySachkov approved these changes Feb 17, 2025

View reviewed changes

This was referenced Feb 17, 2025

[SYCL] Fix post-commit failure for OCL_interop_test.cpp on fpga #16930

Closed

Document the -fintelfpga flag ? #1190

Closed

Merge remote-tracking branch 'intel_llvm/sycl' into fpga-remove-opts

a1eb43f

mdtoguchi temporarily deployed to WindowsCILock February 18, 2025 14:51 — with GitHub Actions Inactive

mdtoguchi temporarily deployed to WindowsCILock February 18, 2025 15:31 — with GitHub Actions Inactive

uditagarwal97 merged commit bae7012 into intel:sycl Feb 18, 2025
31 of 33 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SYCL][Driver][FPGA] Remove support for FPGA related options #16864

[SYCL][Driver][FPGA] Remove support for FPGA related options #16864

Uh oh!

mdtoguchi commented Jan 31, 2025 •

edited

Loading

Uh oh!

Uh oh!

asudarsa left a comment

Uh oh!

asudarsa left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdtoguchi commented Feb 12, 2025

Uh oh!

mdtoguchi commented Feb 18, 2025

Uh oh!

mdtoguchi commented Feb 18, 2025

Uh oh!

Uh oh!

Uh oh!

[SYCL][Driver][FPGA] Remove support for FPGA related options #16864

[SYCL][Driver][FPGA] Remove support for FPGA related options #16864

Uh oh!

Conversation

mdtoguchi commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

asudarsa left a comment

Choose a reason for hiding this comment

Uh oh!

asudarsa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdtoguchi commented Feb 12, 2025

Uh oh!

mdtoguchi commented Feb 18, 2025

Uh oh!

mdtoguchi commented Feb 18, 2025

Uh oh!

Uh oh!

Uh oh!

mdtoguchi commented Jan 31, 2025 •

edited

Loading