[SYCL][E2E][Docs] Update test-mode documentation
#16875
Conversation
ayylol
changed the title
build-only from #16725REQUIRES/UNSUPPORTED in build-only
|
Hey @ayylol can this be undrafted now? |
ayylol
changed the title
REQUIRES/UNSUPPORTED in build-onlytest-mode documentation
|
This is dependent on the changes from #17023 |
sycl/test-e2e/README.md
Outdated
| If an expression's final value is unknown we consider it to have met the | ||
| requirements. The list of device-agnostic features that are not considered |
There was a problem hiding this comment.
Please make a few examples for both REQUIRES and UNSUPPORTED. I'm also not sure about the wording being precise here, but let's start with the examples.
There was a problem hiding this comment.
I added some examples. LMK if anymore should be added or those are fine.
sycl/test-e2e/README.md
Outdated
| lit parameter. Valid build targets are: `spir`,`nvidia`, `amd`, `native_cpu`. | ||
| These correspond to `spir64`, `nvptx64-nvidia-cuda`, `amdgcn-amd-amdhsa`, and | ||
| `native_cpu` triples respectively. Each build target should be separated with | ||
| a semicolon. This parameter is set to just `spir` by default. A test can be |
There was a problem hiding this comment.
Should be set by default to all the available backends configured in the SYCL toolchain used. Not sure if that would be a doc-only change or not.
There was a problem hiding this comment.
Currently, this would require extra non-doc changes.
There was a problem hiding this comment.
Added a bit on build target autodetection from #17141
| in the current lit configuration. | ||
|
|
||
| When executing the test in `build-only`, all `RUN:` lines that do not have a | ||
| run expansion will execute. |
There was a problem hiding this comment.
including {run-aux} ?
There was a problem hiding this comment.
Yep, the point of %{run-aux} is to be able to switch over a line from running at the build stage, to running at the run stage.
| * `UNSUPPORTED: !sg-32`: this would be supported. `sg-32` is evaluated as | ||
| unknown, and the negation of unknown is also unknown. | ||
|
|
||
| #### Common Issues with separate build and run |
There was a problem hiding this comment.
It is maybe unfair to ask, since this part of the doc is pre-existing. But we have this instruction
"Tests that build and execute multiple binaries need to be written such that the output of each compilation has a different name"
and I'd love to see an example what is meant by the solution. "each compilation has a different name".
There was a problem hiding this comment.
Ok, I added an extra sentence with an example.
Also if you wanted more real examples the changes in #15631, are exactly what this is describing.
Ok, latest commit should address those. I also added a couple more examples to show how the triple selection works with regards to require statements. |
|
@intel/llvm-gatekeepers this is ready to merge |
Changes documentation of
build-onlymode to reflect the recent improvements in this mode.