Skip to content

[SYCL] Remove the unused Spec Consts variable #16902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

[SYCL] Remove the unused Spec Consts variable #16902

merged 1 commit into from
Feb 12, 2025

Conversation

slawekptak
Copy link
Contributor

Remove the unused Spec Consts component of the kernel fast cache key.

@slawekptak slawekptak requested a review from a team as a code owner February 6, 2025 11:38
@slawekptak
[SYCL] Remove the unused Spec Consts variable
70cc70b 
Remove the unused Spec Consts component of the kernel
fast cache key.
KseniyaTikhomirova
KseniyaTikhomirova reviewed Feb 10, 2025
View reviewed changes
KseniyaTikhomirova
KseniyaTikhomirova approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@KseniyaTikhomirova KseniyaTikhomirova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec const var is not set for both save & load operations so it is valid to eliminate them for now.

LGTM

@againull againull merged commit d4e22a7 into intel:sycl Feb 12, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KseniyaTikhomirova KseniyaTikhomirova KseniyaTikhomirova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slawekptak @KseniyaTikhomirova @againull