[NFCI][SYCL] Introduce sycl::detail::vec_base
#16976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
force-pushed
the
vec-base
branch
from
2b7bc4f to
0be1dbf
Compare
...in preparation of a future functional change that would require `sycl::vec` to have different ctors depending on the number of elements in it (as will be require by the now-proposed changes to the SYCL specification).
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
force-pushed
the
vec-base
branch
from
0be1dbf to
7b4648a
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
requested review from
KseniyaTikhomirova,
uditagarwal97 and
steffenlarsen
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Feb 12, 2025
uditagarwal97
pushed a commit
that referenced
this pull request
Mar 6, 2025
After #16976, CTS failed to compile due to an assertion being raised in `sycl-post-link`, more specifically while processing a `vec` spec constants at https://github.com/intel/llvm/blob/35fba198274c4a9f00c3f9de21cbd564242850c3/llvm/lib/SYCLLowerIR/SpecConstants.cpp#L593 However, the problem was more general and could be attributed to struct hierarchies. `getElemDefaultValue` was essentially assuming the return type for the spec constant instruction and the type used to initialize the default value for the spec constant had the same "structure" (modulo some padding fields). However, in general, this assumption does not seem to hold. The initializer will essentially have a flattened out structure, while the return type will retain the nested structure. Because of this `emitSpecConstantRecursiveImpl` has been updated to consider this. First, before recursion starts, we recurse the default value initializer in `collectDefinedElements`, collecting information on the children elements of the structure, noting what offset they exists at. Then, we recurse the return type in `emitSpecConstantRecursiveImpl`. When we reach a child element, we default value by using the information we collected earlier. There is some consideration needed for padding - before recursing, we check to see if any child element exists at the offset we are trying to recurse in. If there is none, then we must be at some padding fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...in preparation of a future functional change that would require
sycl::vecto have different ctors depending on the number of elements in it (as will be require by the now-proposed changes to the SYCL specification).