Skip to content

[SYCL][Graph] Fix Windows build fail #17006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

EwanC
Copy link
Contributor

@EwanC EwanC commented Feb 13, 2025

PR #16788 broke the windows post-commit CI when building with icx/icpx https://github.com/intel/llvm/actions/runs/13310637099/job/37172065867

D:\github\_work\llvm\llvm\build\include\sycl\ext\oneapi\experimental\graph.hpp(577,8): error: 'dllexport' attribute ignored [-Werror,-Wignored-attributes]
  577 | struct __SYCL_EXPORT
      |        ^
D:\github\_work\llvm\llvm\build\include\sycl\detail\export.hpp(23,34): note: expanded from macro '__SYCL_EXPORT'
   23 | #define __SYCL_EXPORT __declspec(dllexport)
      |                                  ^
In file included from D:\github\_work\llvm\llvm\src\sycl\unittests\Extensions\EventMode.cpp:9:
In file included from D:\github\_work\llvm\llvm\build\include\sycl\sycl.hpp:11:
In file included from D:\github\_work\llvm\llvm\build\include\sycl\detail\core.hpp:23:
In file included from D:\github\_work\llvm\llvm\build\include\sycl\queue.hpp:34:
D:\github\_work\llvm\llvm\build\include\sycl\ext\oneapi\experimental\graph.hpp(587,8): error: 'dllexport' attribute ignored [-Werror,-Wignored-attributes]
  587 | struct __SYCL_EXPORT
      |        ^
D:\github\_work\llvm\llvm\build\include\sycl\detail\export.hpp(23,34): note: expanded from macro '__SYCL_EXPORT'
   23 | #define __SYCL_EXPORT __declspec(dllexport)
      |                                  ^
2 errors generated.

Fix by not exporting these symbols

PR intel#16788 broke the windows
post-commit CI when building with `icx`/`icpx` https://github.com/intel/llvm/actions/runs/13310637099/job/37172065867

```
D:\github\_work\llvm\llvm\build\include\sycl\ext\oneapi\experimental\graph.hpp(577,8): error: 'dllexport' attribute ignored [-Werror,-Wignored-attributes]
  577 | struct __SYCL_EXPORT
      |        ^
D:\github\_work\llvm\llvm\build\include\sycl\detail\export.hpp(23,34): note: expanded from macro '__SYCL_EXPORT'
   23 | #define __SYCL_EXPORT __declspec(dllexport)
      |                                  ^
In file included from D:\github\_work\llvm\llvm\src\sycl\unittests\Extensions\EventMode.cpp:9:
In file included from D:\github\_work\llvm\llvm\build\include\sycl\sycl.hpp:11:
In file included from D:\github\_work\llvm\llvm\build\include\sycl\detail\core.hpp:23:
In file included from D:\github\_work\llvm\llvm\build\include\sycl\queue.hpp:34:
D:\github\_work\llvm\llvm\build\include\sycl\ext\oneapi\experimental\graph.hpp(587,8): error: 'dllexport' attribute ignored [-Werror,-Wignored-attributes]
  587 | struct __SYCL_EXPORT
      |        ^
D:\github\_work\llvm\llvm\build\include\sycl\detail\export.hpp(23,34): note: expanded from macro '__SYCL_EXPORT'
   23 | #define __SYCL_EXPORT __declspec(dllexport)
      |                                  ^
2 errors generated.
```

Fix by not exporting these symbols
@EwanC
Copy link
Contributor Author

EwanC commented Feb 13, 2025

closing in favor of #17005

@EwanC EwanC closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant