[SYCL] Fix type traits used for shuffle operations #17055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pointer type was incorretly treated as arithemetic type, so the case when user passed, for example, int* varible sycl::select_from_group it ended up mapping to non-existent builtin SubgroupShuffleINTEL(i32*, ...). This is fixed in this PR and now it is mapped to SubgroupShuffleINTEL(i64, ...) * Rename type trait VecTypeIsProhibitedForShuffleEmulation->VecTypeIsProhibitedForNativeShuffle. Old name was confusing. Basically trait is used to determine vec types for which we cannot use native builtins. * Type traits were not completely mutually exclusive leading to compilation error with ambigous definitions for some types. For example, marray<bfloat16, 4> used to satisfy both NonScalar and bitcast traits. So, refactoring was done to make them mutually exclusive and more clear.
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@sergey-semenov Could you please take a look. |
sergey-semenov
approved these changes
Feb 24, 2025
|
Hello! We ran into this issue with oneAPI 2025.0.5. Is there a workaround for this by any chance, or is the only fix from a newer version of SYCL? Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointer type was incorrectly treated as arithmetic type, so the case when user passed, for example,
int*variable tosycl::select_from_groupended up mapping to non-existent built-inSubgroupShuffleINTEL(i32*, ...). This is fixed in this PR and now it is mapped toSubgroupShuffleINTEL(i64, ...)Rename type trait
VecTypeIsProhibitedForShuffleEmulation->VecTypeIsProhibitedForNativeShuffle. Old name was confusing. Basically trait is used to determine vec types for which we cannot use native built-ins.enable_ifs for shuffle overloads were not completely mutually exclusive leading to compilation error with ambiguous definitions for some types. For example,marray<bfloat16, 4>used to satisfy bothNonScalarandBitcasttraits. So, refactoring was done to make them mutually exclusive and more clear.