[SYCL] Make SYCL RT compatible with the new offload entry type #17109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
jsji
reviewed
Feb 21, 2025
| @@ -1869,31 +1869,32 @@ void ProgramManager::addImages(sycl_device_binaries DeviceBinary) { | |||
| for (sycl_offload_entry EntriesIt = EntriesB; EntriesIt != EntriesE; | |||
There was a problem hiding this comment.
will the iterator work when the input binary is using legacy entry format? sizeof entries are different.
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
| ++EntriesIt) { | ||
| sycl_offload_entry EntriesIt; | ||
| auto IncrementEntriesIt = [&]() { | ||
| if (EntriesIt->IsNewOffloadEntryType()) |
There was a problem hiding this comment.
We shouldn't expect a mix of old and new entries, so I think this check should be made once instead of on each increment.
There was a problem hiding this comment.
Done in 8d70601
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/dpcpp-clang-driver-reviewers @intel/dpcpp-tools-reviewers please review the changes. Thanks. |
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
approved these changes
Mar 6, 2025
sergey-semenov
approved these changes
Mar 6, 2025
Co-authored-by: Sergey Semenov <[email protected]>
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Thanks so much for putting this change up. I will add my comments (if any) soon. |
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
asudarsa
reviewed
Mar 7, 2025
asudarsa
reviewed
Mar 7, 2025
asudarsa
reviewed
Mar 7, 2025
asudarsa
reviewed
Mar 7, 2025
asudarsa
reviewed
Mar 7, 2025
asudarsa
reviewed
Mar 7, 2025
asudarsa
reviewed
Mar 7, 2025
asudarsa
reviewed
Mar 7, 2025
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
asudarsa
approved these changes
Mar 10, 2025
adamfidel
pushed a commit
to reble/llvm
that referenced
this pull request
Mar 11, 2025
…#17109) llvm/llvm-project#124018 change the type of offload struct. This PR makes SYCL RT compatible with the new format, while keeping backwards compatibility with the older version (till next ABI-break window). --------- Co-authored-by: Sergey Semenov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm/llvm-project#124018 change the type of offload struct. This PR makes SYCL RT compatible with the new format, while keeping backwards compatibility with the older version (till next ABI-break window).