[SYCL][Test] Add std::complex kernel test. #1711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: haonanya <[email protected]>
bader
reviewed
May 19, 2020
Signed-off-by: haonanya <[email protected]>
Signed-off-by: haonanya <[email protected]>
alexbatashev
previously approved these changes
May 21, 2020
There was a problem hiding this comment.
@haonanya would you consider using some C++ constructs (for example, constexpr and std::array) instead of C?
Anyway, good test suite. My comments should not block the merge of this patch.
|
@haonanya, do you plan to address the comments before the merge? |
Signed-off-by: haonanya [email protected] Define constant using C++ const expression. Co-authored-by: Alexander Batashev <[email protected]>
Signed-off-by: haonanya [email protected] Use C++ std::array to store C++ complex struct. Co-authored-by: Alexander Batashev <[email protected]>
Signed-off-by: haonanya [email protected]. Use C++ std::array to store C++ complex struct. Co-authored-by: Alexander Batashev <[email protected]>
Signed-off-by: haonanya [email protected]. Add include header.
Signed-off-by: haonanya <[email protected]>
Signed-off-by: haonanya <[email protected]>
Signed-off-by: haonanya <[email protected]>
Signed-off-by: haonanya <[email protected]>
|
Hi, @alexbatashev , I already update tests using C++ std::array to replace C array. |
alexbatashev
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: haonanya [email protected]
Add std::complex kernel test.