Skip to content

[SYCL][E2E] Move crashing sub_byte_bitreverse test to unsupported #17126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Feb 21, 2025

It's crashing in IGC and potentially contributing to runner instability.

@sarnex
Copy link
Contributor Author

sarnex commented Feb 24, 2025

Code formatter is wrong, ignoring

@sarnex sarnex marked this pull request as ready for review February 24, 2025 15:40
@sarnex sarnex requested a review from a team as a code owner February 24, 2025 15:40
@sarnex sarnex requested review from MrSidims and vmaksimo February 24, 2025 16:03
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, otherwise LGTM.

// XFAIL: spirv-backend
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16318, CMPLRLLVM-62187
// UNSUPPORTED: spirv-backend
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/16318, CMPLRLLVM-62187
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're doing this because it's crashing in IGC, should we also add IGC link here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok yeah it looks like that should work will make a followup PR now

@sarnex
Copy link
Contributor Author

sarnex commented Feb 24, 2025

merging now to unblock re-enabling testing, will address feedback in followup

@sarnex sarnex merged commit 776af8e into intel:sycl Feb 24, 2025
19 of 20 checks passed
sarnex added a commit that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants