Skip to content

[SYCL] Add test plan for sycl_ext_oneapi_launch_queries extension #17145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 10, 2025

Conversation

lbushi25
Copy link
Contributor

Add test plan for sycl_ext_oneapi_launch_queries extension.

@lbushi25 lbushi25 marked this pull request as ready for review February 24, 2025 18:46
@lbushi25 lbushi25 requested a review from a team as a code owner February 24, 2025 18:46
@cperkinsintel
Copy link
Contributor

Do extensions put their test plans in test-e2e/TestPlans? It seems like that should just be part of the extension.

@lbushi25
Copy link
Contributor Author

lbushi25 commented Mar 3, 2025

Do extensions put their test plans in test-e2e/TestPlans? It seems like that should just be part of the extension.

This particular extension as implemented here does not have its own subdirectory.
I'm not sure whether it is preferred to create a separate subdirectory for the extension and put the test plan there or do what I'm doing in this PR and put it into one folder. @AlexeySachkov , thoughts?

@AlexeySachkov
Copy link
Contributor

Do extensions put their test plans in test-e2e/TestPlans? It seems like that should just be part of the extension.

This particular extension as implemented here does not have its own subdirectory. I'm not sure whether it is preferred to create a separate subdirectory for the extension and put the test plan there or do what I'm doing in this PR and put it into one folder. @AlexeySachkov , thoughts?

My personal preference would be to put test plans alongside tests. For extension tests we have a separate folder per-extension and having a test plan right there would greatly simplify its discoverability

@lbushi25
Copy link
Contributor Author

lbushi25 commented Mar 4, 2025

Do extensions put their test plans in test-e2e/TestPlans? It seems like that should just be part of the extension.

I addressed this.

extension functionality in full, but instead they are focused on making sure
that all APIs are consistent with respect to other APIs.

#### Consistency of `max_subgroup_size` queries
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should also have a test which checks consistency of those queries comparing to device-specific limits - queue-kernel specific limit cannot be higher than device-specific limit (for a device associated with a queue)

Copy link
Contributor

@HPS-1 HPS-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Alexey's comment, other than that this LGTM!

@lbushi25 lbushi25 requested a review from AlexeySachkov March 5, 2025 20:20
@lbushi25
Copy link
Contributor Author

@intel/llvm-gatekeepers This should be good to merge.

@uditagarwal97 uditagarwal97 merged commit 0f5c2ad into intel:sycl Mar 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants