-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Add test plan for sycl_ext_oneapi_launch_queries extension #17145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…5/llvm into launch_queries_test_plan
Do extensions put their test plans in test-e2e/TestPlans? It seems like that should just be part of the extension. |
This particular extension as implemented here does not have its own subdirectory. |
My personal preference would be to put test plans alongside tests. For extension tests we have a separate folder per-extension and having a test plan right there would greatly simplify its discoverability |
I addressed this. |
extension functionality in full, but instead they are focused on making sure | ||
that all APIs are consistent with respect to other APIs. | ||
|
||
#### Consistency of `max_subgroup_size` queries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should also have a test which checks consistency of those queries comparing to device-specific limits - queue-kernel specific limit cannot be higher than device-specific limit (for a device associated with a queue)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Alexey's comment, other than that this LGTM!
@intel/llvm-gatekeepers This should be good to merge. |
…tel#17145) Add test plan for [sycl_ext_oneapi_launch_queries](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_launch_queries.asciidoc) extension.
Add test plan for sycl_ext_oneapi_launch_queries extension.