Skip to content

[DeviceMSAN] Check use-of-uninitialized value on dynamic local memory #17180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Mar 10, 2025
Merged

[DeviceMSAN] Check use-of-uninitialized value on dynamic local memory #17180

merged 39 commits into from
Mar 10, 2025

Conversation

AllanZyne
Copy link
Contributor

@AllanZyne AllanZyne commented Feb 26, 2025 •
edited
Loading

Support check use-of-uninitialized value on dynamic local memory, such as "sycl::local_accessor"

AllanZyne and others added 30 commits January 20, 2025 23:39
@AllanZyne
enhance free test
d8d7eba
@AllanZyne
update ur tag
229ca5c
@kbenzie
Merge remote-tracking branch 'origin/sycl' into review/yang/fix_asan_…
ed13ba0 
…free
@kbenzie
[UR] Bump main tag to 7e38d0a
63b1e52
@AllanZyne
wip
4e204e1
@AllanZyne
Merge branch 'sycl' into review/yang/msan_local_mem
f4bcf64
@AllanZyne
wip
851f0b0
@AllanZyne
tests
cac8b73
@AllanZyne
wip
c35a3cc
@AllanZyne
wip
a439e08
@AllanZyne
Revert "enhance free test"
903836f 
This reverts commit d8d7eba.
@AllanZyne
revert ur tag
7aa7cbe
@AllanZyne
clean code
2af6a2a
@AllanZyne
wip
2ac7139
@AllanZyne
rename e2e tests
ad0639d
@AllanZyne
wip
f16cc47
@AllanZyne
fix lit test
6e8273e
@AllanZyne
fix pre ci
af1682e
@AllanZyne
Merge branch 'sycl' into review/yang/msan_local_mem
4c4480f
@AllanZyne
fix build
7b156f8
@AllanZyne
Merge branch 'sycl' into review/yang/msan_local_mem
5707fca
@AllanZyne
fix format
8b20f23
@AllanZyne
fix format
1bf5182
@AllanZyne
add test
3e7c18c
@AllanZyne
"__msan_set_shadow_static_local" to "__msan_poison_shadow_static_local"
e393c6b
@AllanZyne
wip
802092e
@AllanZyne
fix test fail
69ab100
@AllanZyne
wip
8ecb499
@AllanZyne
update pre ci config
ab12baa
@AllanZyne
Merge branch 'sycl' into review/yang/msan_local_mem
3070bef
@AllanZyne
Copy link
Contributor Author

@intel/unified-runtime-reviewers, please review. Thanks.

yingcong-wu
yingcong-wu reviewed Mar 5, 2025
View reviewed changes
Copy link
Contributor

@yingcong-wu yingcong-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at a glance. I will leave the actual review to @zhaomaosu .

zhaomaosu
zhaomaosu approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@zhaomaosu zhaomaosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllanZyne
Copy link
Contributor Author

Failed tests are unrelated to this PR.

@AllanZyne
Copy link
Contributor Author

Kindly ping @intel/unified-runtime-reviewers.

@AllanZyne
Copy link
Contributor Author

@intel/llvm-gatekeepers, please merge. Failed tests are unrelated to this PR.

@uditagarwal97
Copy link
Contributor

@intel/llvm-gatekeepers, please merge. Failed tests are unrelated to this PR.

Hi @AllanZyne, for the unrelated failure(s), can you please share the GH issue for those? Or create one if it doesn't already exist?

@AllanZyne
Copy link
Contributor Author

@intel/llvm-gatekeepers, please merge. Failed tests are unrelated to this PR.

Hi @AllanZyne, for the unrelated failure(s), can you please share the GH issue for those? Or create one if it doesn't already exist?

I couldn't find it in issues, so I created one: #17369

@uditagarwal97
Copy link
Contributor

@intel/llvm-gatekeepers, please merge. Failed tests are unrelated to this PR.

Hi @AllanZyne, for the unrelated failure(s), can you please share the GH issue for those? Or create one if it doesn't already exist?

I couldn't find it in issues, so I created one: #17369

thanks!

@uditagarwal97 uditagarwal97 merged commit 04fd002 into sycl Mar 10, 2025
31 of 32 checks passed
@AllanZyne AllanZyne deleted the review/yang/msan_dynamic_local branch March 10, 2025 02:42
adamfidel pushed a commit to reble/llvm that referenced this pull request Mar 11, 2025
@AllanZyne @kbenzie @adamfidel
[DeviceMSAN] Check use-of-uninitialized value on dynamic local memory (…
60afe61 
…intel#17180)

Support check use-of-uninitialized value on dynamic local memory, such
as "sycl::local_accessor"

---------

Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongreig aarongreig aarongreig approved these changes

@yingcong-wu yingcong-wu yingcong-wu left review comments

@zhaomaosu zhaomaosu zhaomaosu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AllanZyne @uditagarwal97 @aarongreig @zhaomaosu @yingcong-wu @kbenzie