Skip to content

[SYCL] Fix memory leaks. #17234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

maarquitos14
Copy link
Contributor

@maarquitos14 maarquitos14 commented Feb 28, 2025

Adding missing sycl::free calls to sycl/test-e2e/DeviceLib/built-ins/offload-prec-div-sqrt.cpp.

@maarquitos14 maarquitos14 requested a review from a team as a code owner February 28, 2025 09:37
@maarquitos14 maarquitos14 requested review from uditagarwal97 and MrSidims and removed request for uditagarwal97 February 28, 2025 09:37
@maarquitos14
Copy link
Contributor Author

This PR is only changing one test, and it's a different one than the failing test, so I don't see how that can be related.

Copy link
Contributor

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maarquitos14
Copy link
Contributor Author

This PR is only changing one test, and it's a different one than the failing test, so I don't see how that can be related.

@intel/llvm-gatekeepers I think this is ready to merge.

@uditagarwal97
Copy link
Contributor

This PR is only changing one test, and it's a different one than the failing test, so I don't see how that can be related.

@intel/llvm-gatekeepers I think this is ready to merge.

Created a new GH issue for the unrelated test failure: #17248

@uditagarwal97 uditagarwal97 merged commit e31ff53 into intel:sycl Feb 28, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants