Skip to content

[SYCL][E2E] Disable AOT tests on more platforms #17317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 5, 2025
Merged

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Mar 5, 2025

Failing in more cases in the nightly

https://github.com/intel/llvm/actions/runs/13667656648

@sarnex sarnex marked this pull request as ready for review March 5, 2025 15:30
@sarnex sarnex requested a review from a team as a code owner March 5, 2025 15:30
@sarnex sarnex requested a review from maarquitos14 March 5, 2025 15:30
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex sarnex requested a review from a team as a code owner March 5, 2025 18:28
@sarnex sarnex temporarily deployed to WindowsCILock March 5, 2025 18:30 — with GitHub Actions Inactive
@maarquitos14
Copy link
Contributor

@sarnex XFAIL is no longer good enough because now the tests are crashing instead of running to completion but with wrong result, right?

@sarnex
Copy link
Contributor Author

sarnex commented Mar 5, 2025

@maarquitos14 That's my understanding

@sarnex
Copy link
Contributor Author

sarnex commented Mar 5, 2025

Merging now to fix precommit

@sarnex sarnex merged commit e780eff into intel:sycl Mar 5, 2025
20 checks passed
@sarnex sarnex temporarily deployed to WindowsCILock March 5, 2025 19:28 — with GitHub Actions Inactive
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants