Skip to content

[CI] Use prebuilt E2E binaries when running on Windows Gen12 #17335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 10, 2025
Merged

Conversation

ayylol
Copy link
Contributor

@ayylol ayylol commented Mar 6, 2025

Windows Gen12 job, previously took around 42min. With prebuilt binaries building the e2e tests takes around 12min, and running them took around 6min.

@ayylol ayylol temporarily deployed to WindowsCILock March 7, 2025 22:54 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock March 13, 2025 21:07 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock March 14, 2025 13:48 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock March 14, 2025 20:07 — with GitHub Actions Inactive
# In contrast to `cpu` feature this is a compile-time feature, which is needed
# to check if we can build cpu AOT tests.
if "opencl:cpu" in sycl_ls_output:
config.available_features.add("opencl-cpu-rt")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenCL CPU runtimes were installed on the windows CI machines, so those tests are now able to compile there. However I'm still introducing this feature so that we can mark the tests that would fail to compile if there is no CPU rt as requiring this. This is basically a build mode analogue of the any-device-is-cpu feature, however the reason this needs to be a separate feature rather than changing any-device-is-cpu to also be available during the build stage, is that we already use that feature to mark tests that do not necessarily need a cpu device listed to be able to compile, but do need a cpu device to be able to run.

Copy link
Contributor Author

@ayylol ayylol Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, for those who approved previously when this pr added XFAILs (@fabiomestre and @aarongreig). I changed those to require this feature instead.

@ayylol
Copy link
Contributor Author

ayylol commented Apr 9, 2025

@intel/syclcompat-lib-reviewers friendly ping

Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci and SYCL RT changes LGTM.

@ayylol
Copy link
Contributor Author

ayylol commented Apr 10, 2025

@intel/llvm-gatekeepers this is ready to merge, thanks

@sarnex
Copy link
Contributor

sarnex commented Apr 10, 2025

Praise be!

@sarnex sarnex merged commit 2ee62ad into sycl Apr 10, 2025
37 of 40 checks passed
@ayylol ayylol deleted the win-e2esplit branch April 10, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants