-
Notifications
You must be signed in to change notification settings - Fork 787
[CI] Use prebuilt E2E binaries when running on Windows Gen12 #17335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# In contrast to `cpu` feature this is a compile-time feature, which is needed | ||
# to check if we can build cpu AOT tests. | ||
if "opencl:cpu" in sycl_ls_output: | ||
config.available_features.add("opencl-cpu-rt") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenCL CPU runtimes were installed on the windows CI machines, so those tests are now able to compile there. However I'm still introducing this feature so that we can mark the tests that would fail to compile if there is no CPU rt as requiring this. This is basically a build
mode analogue of the any-device-is-cpu
feature, however the reason this needs to be a separate feature rather than changing any-device-is-cpu
to also be available during the build
stage, is that we already use that feature to mark tests that do not necessarily need a cpu device listed to be able to compile, but do need a cpu device to be able to run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, for those who approved previously when this pr added XFAILs (@fabiomestre and @aarongreig). I changed those to require this feature instead.
@intel/syclcompat-lib-reviewers friendly ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ci and SYCL RT changes LGTM.
@intel/llvm-gatekeepers this is ready to merge, thanks |
Praise be! |
Windows Gen12 job, previously took around 42min. With prebuilt binaries building the e2e tests takes around 12min, and running them took around 6min.