Skip to content

[SYCL][E2E] Re-enable copy_dynamic_size on CUDA #17352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

npmiller
Copy link
Contributor

@npmiller npmiller commented Mar 7, 2025

I don't know what fixed it, but this is fixed on the sycl branch and in the latest nightlies.

Fixes #16968

@npmiller npmiller requested a review from a team as a code owner March 7, 2025 14:25
@npmiller npmiller requested a review from uditagarwal97 March 7, 2025 14:25
@ayylol
Copy link
Contributor

ayylol commented Mar 7, 2025

I don't know what fixed it, but this is fixed on the sycl branch and in the latest nightlies.

The issue manifested specifically when the tests were built for multiple triples, rather than just nvptx triple. I'm guessing those passes are likely only building nvptx triple?

If it still fails here we could do a more fine grained unsupported statement like UNSUPPORTED: cuda && !build-mode so they still run outside of the pre-commit where they pass. Or XFAIL: cuda && run-mode && !build-mode

@npmiller
Copy link
Contributor Author

npmiller commented Mar 7, 2025

No, I did try it building with multiple triples, and I can reproduce the failure with an older nightly build, see:

March 3rd nightly:

$ clang++ -fsycl -fsycl-targets=nvidia_gpu_sm_80,spir64 copy_dynamic_size.cpp -o c
$ ./c
<CUDA>[ERROR]: 
UR CUDA ERROR:
	Value:           700
	Name:            CUDA_ERROR_ILLEGAL_ADDRESS
	Description:     an illegal memory access was encountered
	Function:        wait
	Source Location: /home/llvm/unified-runtime/source/adapters/cuda/event.cpp:134

terminate called after throwing an instance of 'sycl::_V1::exception'
  what():  Native API failed. Native API returns: 2147483646 (UR_RESULT_ERROR_UNKNOWN)
Aborted
$

March 6 nightly:

$ clang++ -fsycl -fsycl-targets=nvidia_gpu_sm_80,spir64 copy_dynamic_size.cpp -o c
$ ./c
$

So I do think it's actually fixed, thanks for checking!

It might have gotten fixed in upstream LLVM, since there was a pulldown merged recently.

@npmiller
Copy link
Contributor Author

@intel/llvm-gatekeepers This is ready to merge

Only failure disabled in #17344 and tracked in #17212

Failed Tests (1):
  SYCL :: bindless_images/sampling_2D.cpp

@sarnex sarnex merged commit 1561b88 into intel:sycl Mar 10, 2025
25 of 27 checks passed
adamfidel pushed a commit to reble/llvm that referenced this pull request Mar 11, 2025
I don't know what fixed it, but this is fixed on the `sycl` branch and
in the latest nightlies.

Fixes intel#16968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WorkGroupScratchMemory/copy_dynamic_size.cpp Fails on cuda when built for multiple triples
4 participants