[SYCL] Enforce "construct from platform" mock test execution #1738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The case was not being run due to platforms' default construction as host platforms. Signed-off-by: Artem Gindinson <[email protected]>
KarachunIvan
approved these changes
May 21, 2020
v-klochkov
approved these changes
May 21, 2020
s-kanaev
approved these changes
May 22, 2020
Fznamznon
pushed a commit
to Fznamznon/llvm
that referenced
this pull request
Nov 29, 2022
The translator was crashing in case if builin GV was accessed via GEP without AS cast due to incorrect assumption. Signed-off-by: Sidorov, Dmitry <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@e52f5d9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case was not being run due to platforms' default
construction as host platforms.
Signed-off-by: Artem Gindinson [email protected]