Skip to content

[DeviceSanitizer] Skip adding device sanitizers internal variable to bundler symbol table #17399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 24, 2025

Conversation

yingcong-wu
Copy link
Contributor

@yingcong-wu yingcong-wu commented Mar 12, 2025

__MsanDeviceGlobalMetadata etc are sanitizer internal variables, and should not be bundled to the symbol table.

@yingcong-wu yingcong-wu requested a review from a team as a code owner March 12, 2025 01:33
@yingcong-wu yingcong-wu changed the title save [DeviceMemorySanitizer][OpenMP] Skip bundling __MsanDeviceGlobalMetadata Mar 12, 2025
@yingcong-wu yingcong-wu changed the title [DeviceMemorySanitizer][OpenMP] Skip bundling __MsanDeviceGlobalMetadata [DeviceMemorySanitizer] Skip bundling __MsanDeviceGlobalMetadata Mar 12, 2025
@yingcong-wu yingcong-wu changed the title [DeviceMemorySanitizer] Skip bundling __MsanDeviceGlobalMetadata [DeviceSanitizer] Skip bundling device sanitizers internal variable Mar 18, 2025
@yingcong-wu yingcong-wu changed the title [DeviceSanitizer] Skip bundling device sanitizers internal variable [DeviceSanitizer] Skip adding device sanitizers internal variable to bundler symbol table Mar 18, 2025
@yingcong-wu
Copy link
Contributor Author

Hi @dpcpp-tools-reviewers , could you please help review this PR? Thanks.

@yingcong-wu
Copy link
Contributor Author

Hi @intel/llvm-gatekeepers , this PR is ready to merge. Thanks

@uditagarwal97 uditagarwal97 merged commit 7a83f21 into intel:sycl Mar 24, 2025
22 checks passed
KornevNikita pushed a commit that referenced this pull request Jun 3, 2025
…bundler symbol table (#17399)

`__MsanDeviceGlobalMetadata` etc are sanitizer internal variables, and
should not be bundled to the symbol table.
KornevNikita pushed a commit to KornevNikita/llvm that referenced this pull request Jun 10, 2025
…bundler symbol table (intel#17399)

`__MsanDeviceGlobalMetadata` etc are sanitizer internal variables, and
should not be bundled to the symbol table.
AlexeySachkov pushed a commit that referenced this pull request Jun 18, 2025
Cherry-pick commits that reached the internal branch between intel/llvm
cutoff and release branch pulldown.

Included patches:

---

[DeviceSanitizer][Coverity] die when fail to create context (#17600)

There is uncaught exception through logger creation in sanitizer layer
`context_t` 's creation. We catch exceptions here and die if the
creation of sanitizer layer context fails.

Patch-by: Wu Yingcong <[email protected]>

---

[DeviceSanitizer] Skip adding device sanitizers internal variable to bundler symbol table (#17399)

`__MsanDeviceGlobalMetadata` etc are sanitizer internal variables, and
should not be bundled to the symbol table.

Patch-by: Wu Yingcong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants