[UR] Update some naming inconsistencies for UR enums #17406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
force-pushed
the
martin/namingConsistency
branch
from
e5fdd0a to
e41b561
Compare
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
martygrant
force-pushed
the
martin/namingConsistency
branch
from
e41b561 to
d804ef2
Compare
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
martygrant
force-pushed
the
martin/namingConsistency
branch
from
d804ef2 to
85d6914
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
force-pushed
the
martin/namingConsistency
branch
from
85d6914 to
5971de5
Compare
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
martygrant
force-pushed
the
martin/namingConsistency
branch
from
5971de5 to
35f1388
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
force-pushed
the
martin/namingConsistency
branch
from
35f1388 to
0b5115b
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
npmiller
reviewed
Mar 17, 2025
AlexeySachkov
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
sycl/doc changes LGTM. This is an interface/API break to some extent, but I think that it is fine to have it, because the variable is explicitly documented under "debugging" section with a disclaimer that it should not be used in production code. As such, I think that our right to change it without prior notice is reserved for us.
If we want to make the transition smoother, then I would suggest to print a warning message to stderr if the old variable is used
aarongreig
approved these changes
Mar 19, 2025
martygrant
force-pushed
the
martin/namingConsistency
branch
from
0b5115b to
e44b6b6
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
npmiller
approved these changes
Mar 20, 2025
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/bindless-images-reviewers @intel/dpcpp-nativecpu-reviewers @intel/llvm-reviewers-runtime friendly ping for a review please |
isaacault
approved these changes
Mar 21, 2025
Seanst98
reviewed
Mar 21, 2025
martygrant
force-pushed
the
martin/namingConsistency
branch
from
e44b6b6 to
424f0d5
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
coldav
approved these changes
Mar 21, 2025
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Seanst98
approved these changes
Mar 21, 2025
…ENABLE_IMAGE_SUPPORT env variable, SYCL_UR_CUDA_ENABLE_IMAGE_SUPPORT should be used instead.
martygrant
force-pushed
the
martin/namingConsistency
branch
from
424f0d5 to
fecd0c0
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
pushed a commit
that referenced
this pull request
May 27, 2025
- Renamed `X_SUPPORTED` enums to be consistent with majority of UR enums named `X_SUPPORT` - Renamed some enums to be called `X_SUPPORT` where they return true/false - Renamed `SYCL_PI_CUDA_ENABLE_IMAGE_SUPPORT` to `SYCL_UR_CUDA_ENABLE_IMAGE_SUPPORT`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X_SUPPORTEDenums to be consistent with majority of UR enums namedX_SUPPORTX_SUPPORTwhere they return true/falseSYCL_PI_CUDA_ENABLE_IMAGE_SUPPORTtoSYCL_UR_CUDA_ENABLE_IMAGE_SUPPORT