[clang][SYCL] Disable float128 device mode diagnostic (#128513) #17430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diagnostic is disabled for device compilation as float128 is not supported on the device side. Other diagnostics are already covering the cases where float128 is actually used in the kernel code, and it's already tested for in the existing test. This is expanding on the patch 318bff6 that handled this for cuda compilation.
npmiller
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Test failure is unrelated and tracked in: #17439 |
|
Even though we'll get this at the next pulldown, it'd be nice if we could merge this soon so I don't have to cherry pick it every time I try and build a new branch. @intel/dpcpp-cfe-reviewers any chance we could expedite the review to help those using modern glibc? |
Fznamznon
approved these changes
Mar 14, 2025
|
@intel/llvm-gatekeepers this is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of: llvm/llvm-project#128513
Fixes: #16903
This diagnostic is disabled for device compilation as float128 is not supported on the device side.
Other diagnostics are already covering the cases where float128 is actually used in the kernel code, and it's already tested for in the existing test.
This is expanding on the patch 318bff6 that handled this for cuda compilation.