Skip to content

[SYCL][libdevice] Keep sign bit of result for std::sin(-0) #17440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025
Merged

[SYCL][libdevice] Keep sign bit of result for std::sin(-0) #17440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24abd41
[SYCL][libdevice] Keep siginbit of result for std::sin(-0)
jinge90 Mar 13, 2025
131f5e9
reverse macro
jinge90 Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions libdevice/fallback-cmath.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,13 @@ float __devicelib_fmaf(float x, float y, float z) {
return __spirv_ocl_fma(x, y, z);
}

#if defined(__SPIR__) || defined(__SPIRV__)
DEVICE_EXTERN_C_INLINE
float __devicelib_sinf(float x) { return (x == 0.0f) ? x : __spirv_ocl_sin(x); }
#else
DEVICE_EXTERN_C_INLINE
float __devicelib_sinf(float x) { return __spirv_ocl_sin(x); }
#endif

DEVICE_EXTERN_C_INLINE
float __devicelib_cosf(float x) { return __spirv_ocl_cos(x); }
Expand Down