[Sycl][Graph] Reimplement topological sort algorithm #17495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
EwanC
reviewed
Mar 18, 2025
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
EwanC
approved these changes
Mar 18, 2025
The current implementation of the topological sort algorithm relies on a recursive function. This causes stack overflow issues when the graphs are very large. There is also a performance issue in the current implementation related to the way std::find() is being used. This commit reimplements the topological sort algorithm to fix these issues: - Uses an iterative approach instead of recursive. - Removes the use of std::find() and instead relies on keeping the state with a helper variable. - Reimplements the cycle checking algorithm to use the same topological sort function as the one used during scheduling. - Fixes a bug with make_edge() not removing the dest node from the list of root nodes.
fabiomestre
force-pushed
the
fabio/topological_sort
branch
from
349abd6 to
c530bad
Compare
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers This should be ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the topological sort algorithm relies on a recursive function. This causes stack overflow issues when the graphs are very large. There is also a performance issue in the current implementation related to the way std::find() is being used.
This commit reimplements the topological sort algorithm to fix these issues: