Skip to content

[GHA] Uplift Linux GPU RT version to 25.09.32961.5 #17498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 21, 2025

Conversation

bb-sycl
Copy link
Contributor

@bb-sycl bb-sycl commented Mar 18, 2025

Scheduled drivers uplift

@bb-sycl bb-sycl requested a review from a team as a code owner March 18, 2025 03:14
@sarnex sarnex self-assigned this Mar 18, 2025
@sarnex sarnex force-pushed the ci/update_gpu_driver-linux-25.09.32961.5 branch from 49b94bd to e26bb0f Compare March 18, 2025 14:52
@sarnex sarnex requested a review from a team as a code owner March 18, 2025 14:52
@sarnex sarnex temporarily deployed to WindowsCILock March 18, 2025 14:53 — with GitHub Actions Inactive
@sarnex sarnex requested a review from YuriPlyakhin March 18, 2025 16:49
@sarnex sarnex temporarily deployed to WindowsCILock March 18, 2025 16:49 — with GitHub Actions Inactive
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm wondering how these tests pass on BMG and did not pass on PVC.
The implementation/drivers should be the same for both platforms,...

@sarnex
Copy link
Contributor

sarnex commented Mar 18, 2025

No idea and not touching it :P

@YuriPlyakhin
Copy link
Contributor

No idea and not touching it :P

I guess, it is because they got into unsupported list, due to several backends are being tested on PVC.

@YuriPlyakhin
Copy link
Contributor

@sarnex , I see you have some problems with conditions for Matrix test. I'm pretty sure, if you just remove xfail, the test should pass. So, it might be easier way. Up to you.

@sarnex sarnex force-pushed the ci/update_gpu_driver-linux-25.09.32961.5 branch from c66f631 to 15ac3c3 Compare March 19, 2025 16:00
@sarnex sarnex temporarily deployed to WindowsCILock March 19, 2025 16:00 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock March 19, 2025 16:43 — with GitHub Actions Inactive
@sarnex
Copy link
Contributor

sarnex commented Mar 19, 2025

@YuriPlyakhin Do you mean just the XPASSing test SYCL :: Matrix/SG32/get_coordinate_ops.cpp or all of them?

@YuriPlyakhin
Copy link
Contributor

YuriPlyakhin commented Mar 19, 2025

@YuriPlyakhin Do you mean just the XPASSing test SYCL :: Matrix/SG32/get_coordinate_ops.cpp or all of them?

I mean, the best is to try removing XFAIL from all that you touched in this PR and that are passing on BMG and see how it goes. My bet is all should just pass on any GPU, where matrix and specific tested feature is supported.
But at least, if you have problems with condition of coordinate test and don't want to touch others, you can try removing xfail completely from this test.

Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex sarnex temporarily deployed to WindowsCILock March 19, 2025 18:37 — with GitHub Actions Inactive
@sarnex
Copy link
Contributor

sarnex commented Mar 19, 2025

Hopefully latest commit is what you meant

Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex
Copy link
Contributor

sarnex commented Mar 21, 2025

@YuriPlyakhin Some tests failed when removing the XFAIL, so I XFAILed those only in the newly failing cases. Hopefully these changes are okay, please take a final look before I merge :)

Postcommit passed

@sarnex
Copy link
Contributor

sarnex commented Mar 21, 2025

Actually I'm merging this now because it conflicts with Andrei's PR and I want to beat him :P

If there's any feedback, happy to address post commit

@sarnex sarnex merged commit 8fcd4de into sycl Mar 21, 2025
39 of 41 checks passed
@aelovikov-intel aelovikov-intel deleted the ci/update_gpu_driver-linux-25.09.32961.5 branch March 21, 2025 14:35
@YuriPlyakhin
Copy link
Contributor

@YuriPlyakhin Some tests failed when removing the XFAIL, so I XFAILed those only in the newly failing cases. Hopefully these changes are okay, please take a final look before I merge :)

Postcommit passed

Thank you @sarnex , your changes make sense to me.

AlexeySachkov pushed a commit that referenced this pull request May 28, 2025
This is from #17498

Patch-by: Sarnie, Nick <[email protected]>
Co-authored-by: Yury Plyakhin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants