-
Notifications
You must be signed in to change notification settings - Fork 787
[GHA] Uplift Linux GPU RT version to 25.09.32961.5 #17498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
49b94bd
to
e26bb0f
Compare
sycl/test-e2e/Matrix/SG32/joint_matrix_int8_rowmajorA_rowmajorB.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/Matrix/joint_matrix_16bit_colmajorA_colmajorB.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm wondering how these tests pass on BMG and did not pass on PVC.
The implementation/drivers should be the same for both platforms,...
No idea and not touching it :P |
I guess, it is because they got into |
@sarnex , I see you have some problems with conditions for Matrix test. I'm pretty sure, if you just remove xfail, the test should pass. So, it might be easier way. Up to you. |
Co-authored-by: Yury Plyakhin <[email protected]>
Co-authored-by: Yury Plyakhin <[email protected]>
Co-authored-by: Yury Plyakhin <[email protected]>
Co-authored-by: Yury Plyakhin <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
c66f631
to
15ac3c3
Compare
@YuriPlyakhin Do you mean just the XPASSing test SYCL :: Matrix/SG32/get_coordinate_ops.cpp or all of them? |
I mean, the best is to try removing |
Signed-off-by: Sarnie, Nick <[email protected]>
Hopefully latest commit is what you meant |
Signed-off-by: Sarnie, Nick <[email protected]>
@YuriPlyakhin Some tests failed when removing the XFAIL, so I XFAILed those only in the newly failing cases. Hopefully these changes are okay, please take a final look before I merge :) Postcommit passed |
Actually I'm merging this now because it conflicts with Andrei's PR and I want to beat him :P If there's any feedback, happy to address post commit |
Thank you @sarnex , your changes make sense to me. |
This is from #17498 Patch-by: Sarnie, Nick <[email protected]> Co-authored-by: Yury Plyakhin <[email protected]>
Scheduled drivers uplift