Skip to content

[CI] Add SYCL-CTS on Win #17501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

[CI] Add SYCL-CTS on Win #17501

merged 1 commit into from
Mar 18, 2025

Conversation

KornevNikita
Copy link
Contributor

This patch adds SYCL-CTS build&launch on Win.
Also prepare the workflow for separate actions like it was done for Linux.

This patch adds SYCL-CTS build&launch on Win.
Also prepare the workflow for separate actions like it was done for
Linux.
@KornevNikita KornevNikita requested a review from a team as a code owner March 18, 2025 11:04
@KornevNikita
Copy link
Contributor Author

Example run: https://github.com/intel/llvm/actions/runs/13906335452
e2e fail on win is expected as I used the latest nightly build instead of building the compiler to save the resources.
I've also built only one cts test category, but I've verified that we can successfully build the full scope - https://github.com/intel/llvm/actions/runs/13899641210

Copy link
Contributor

@ayylol ayylol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

uses: ./.github/workflows/sycl-windows-run-tests.yml
with:
name: Build SYCL-CTS for Windows
runner: '["Windows", "build-e2e"]'
Copy link
Contributor

@sarnex sarnex Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry why are we using build-e2e here? i added that for david to test his work just as a debugging thing for him. if we want it to mean fast windows build runner, thats fine, but just want to be clear

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it would be much better to use a fast machine here. Which label should I use instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats fine, ill add build-e2e to the fast machines, pr is fine as-is

@KornevNikita
Copy link
Contributor Author

The failure is known - #17486

@KornevNikita
Copy link
Contributor Author

@intel/dpcpp-devops-reviewers can we merge this one?

@sarnex sarnex merged commit 0f04f66 into sycl Mar 18, 2025
21 of 22 checks passed
@bader bader deleted the win-cts branch March 18, 2025 17:52
KornevNikita added a commit that referenced this pull request Mar 19, 2025
#17501 enabled CTS on win.
But for this patch I used the old version of cts/action.yml (before
#17228). So it caused the Nightly
failure - https://github.com/intel/llvm/actions/runs/13938048645.
This patch aligns windows/cts/action.yml with the linux version.
aelovikov-intel pushed a commit that referenced this pull request Mar 19, 2025
#17501 enabled CTS on win. But for
this patch I used the old version of cts/action.yml (before
#17228). So it caused the Nightly
failure - https://github.com/intel/llvm/actions/runs/13938048645. This
patch aligns windows/cts/action.yml with the linux version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants