[UR][CUDA][HIP] Add missing catch for native commands #17524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This UR entry point calls a user function pointer, which may throw exceptions so we need an exception catchall there to ensure they don't cross the UR C API boundary. It's unclear if exceptions should even be allowed in these user functions, but this is still a worthwhile precaution.
frasercrmck
approved these changes
Mar 19, 2025
|
@intel/llvm-gatekeepers this is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This UR entry point calls a user function pointer, which may throw exceptions so we need an exception catchall there to ensure they don't cross the UR C API boundary.
It's unclear if exceptions should even be allowed in these user functions, but this is still a worthwhile precaution.