Skip to content

[UR] Fix Loader Negative Prefilters #17528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2025
Merged

Conversation

isaacault
Copy link
Contributor

This commit fixes #17086.

@isaacault isaacault requested a review from a team as a code owner March 19, 2025 14:25
@isaacault
Copy link
Contributor Author

CI Failure tracked with #17535

@@ -1,3 +1,14 @@
#
# Copyright (C) 2022-2023 Intel Corporation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

years need updating

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, done.

@kbenzie
Copy link
Contributor

kbenzie commented Mar 19, 2025

CI Failure tracked with #17535

Given this is touching device filter I think we need to be much more certain this PR isn't introducing these failures.

Copy link
Contributor

@aarongreig aarongreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add the [UR] prefix to the PR title, otherwise looks good.

@isaacault isaacault changed the title Fix: UR Loader Negative Prefilters [UR] Fix Loader Negative Prefilters Mar 20, 2025
@isaacault
Copy link
Contributor Author

@intel/llvm-gatekeepers This is ready. Please merge.

@isaacault
Copy link
Contributor Author

@intel/llvm-gatekeepers Ping.

@uditagarwal97 uditagarwal97 merged commit bf20e6e into intel:sycl Mar 23, 2025
30 checks passed
KornevNikita pushed a commit that referenced this pull request Jun 3, 2025
KornevNikita pushed a commit to KornevNikita/llvm that referenced this pull request Jun 10, 2025
AlexeySachkov pushed a commit that referenced this pull request Jun 12, 2025
Cherry-pick commits that reached the internal branch between intel/llvm
cutoff and release branch pulldown.

Patches included:

---

[Coverity][UR] Remove noexcept keywords from pool_manager methods (#17678)

This should fix coverity issues in `ur_pool_manager.hpp`, `ur_util.hpp`
and `ur_adapter_registry.hpp` files reported in:
https://coverity.devtools.intel.com/prod6/#/project-view/26752/10020

Patch-by: Krzysztof Święcicki <[email protected]>

---

[UR][L0] Enable support for using L0 spec External Semaphores (#17671)

- Implements the spec version of the L0 Extension External Semaphores
- Implements handling the translation of handles if the driver only
supports the EXP functions.

Patch-by: Neil R. Spruit <[email protected]>

---

[UR][L0] Memory interop support given external buffer (#17458)

Enable L0 to directly import the memory allocated for NPU/iGPU and let
SYCL kernel running on iGPU be able to directly access the data it will
reduce the overhead of data movement between NPU/iGPU and iGPU.

Patch-by: Zhang, Winston <[email protected]>
Co-authored-by: Peter Žužek <[email protected]>

---

[UR] Fix Loader Negative Prefilters (#17528)

This commit fixes #17086.

Patch-by: Isaac Ault <[email protected]>

---

[UR] Remove unnecessary null pointer check in OpenCL command buffer code, and update declaration of filter lamba to avoid copies (#17615)

Patch-by: Martin Grant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UR] Loader prefilter negative filters behave unexpectedly.
5 participants