Skip to content

remove terminating semicolons from do-while-0 #17554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025
Merged

remove terminating semicolons from do-while-0 #17554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions unified-runtime/source/adapters/native_cpu/common.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@ extern thread_local char ErrorMessage[MaxMessageSize];
__FUNCTION__, __FILE__, __LINE__); \
\
return UR_RESULT_ERROR_UNSUPPORTED_FEATURE; \
} while (false);
} while (false)

#define CONTINUE_NO_IMPLEMENTATION \
do { \
logger::warning("Not Implemented : {} - File : {} / Line : {}", \
__FUNCTION__, __FILE__, __LINE__); \
return UR_RESULT_SUCCESS; \
} while (false);
} while (false)

#define CASE_UR_UNSUPPORTED(not_supported) \
case not_supported: \
Expand Down
6 changes: 3 additions & 3 deletions unified-runtime/source/adapters/native_cpu/context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urContextGetNativeHandle(
ur_context_handle_t hContext, ur_native_handle_t *phNativeContext) {
std::ignore = hContext;
std::ignore = phNativeContext;
DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}

UR_APIEXPORT ur_result_t UR_APICALL urContextCreateWithNativeHandle(
Expand All @@ -84,7 +84,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urContextCreateWithNativeHandle(
std::ignore = pProperties;
std::ignore = phContext;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}

UR_APIEXPORT ur_result_t UR_APICALL urContextSetExtendedDeleter(
Expand All @@ -94,5 +94,5 @@ UR_APIEXPORT ur_result_t UR_APICALL urContextSetExtendedDeleter(
std::ignore = pfnDeleter;
std::ignore = pUserData;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}
2 changes: 1 addition & 1 deletion unified-runtime/source/adapters/native_cpu/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetNativeHandle(
std::ignore = hDevice;
std::ignore = phNativeDevice;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}

UR_APIEXPORT ur_result_t UR_APICALL urDeviceCreateWithNativeHandle(
Expand Down
6 changes: 3 additions & 3 deletions unified-runtime/source/adapters/native_cpu/kernel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ urKernelSetArgSampler(ur_kernel_handle_t hKernel, uint32_t argIndex,
std::ignore = pProperties;
std::ignore = hArgValue;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}

UR_APIEXPORT ur_result_t UR_APICALL
Expand Down Expand Up @@ -290,7 +290,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urKernelGetNativeHandle(
std::ignore = hKernel;
std::ignore = phNativeKernel;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}

UR_APIEXPORT ur_result_t UR_APICALL urKernelCreateWithNativeHandle(
Expand All @@ -304,7 +304,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urKernelCreateWithNativeHandle(
std::ignore = pProperties;
std::ignore = phKernel;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}

UR_APIEXPORT ur_result_t UR_APICALL urKernelGetSuggestedLocalWorkSize(
Expand Down
14 changes: 7 additions & 7 deletions unified-runtime/source/adapters/native_cpu/memory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urMemImageCreate(
std::ignore = pHost;
std::ignore = phMem;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}

UR_APIEXPORT ur_result_t UR_APICALL urMemBufferCreate(
Expand Down Expand Up @@ -65,7 +65,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urMemBufferCreate(
UR_APIEXPORT ur_result_t UR_APICALL urMemRetain(ur_mem_handle_t hMem) {
std::ignore = hMem;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}

UR_APIEXPORT ur_result_t UR_APICALL urMemRelease(ur_mem_handle_t hMem) {
Expand Down Expand Up @@ -117,7 +117,7 @@ urMemGetNativeHandle(ur_mem_handle_t hMem, ur_device_handle_t hDevice,
std::ignore = hDevice;
std::ignore = phNativeMem;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}

UR_APIEXPORT ur_result_t UR_APICALL urMemBufferCreateWithNativeHandle(
Expand All @@ -128,7 +128,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urMemBufferCreateWithNativeHandle(
std::ignore = pProperties;
std::ignore = phMem;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}

UR_APIEXPORT ur_result_t UR_APICALL urMemImageCreateWithNativeHandle(
Expand All @@ -142,7 +142,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urMemImageCreateWithNativeHandle(
std::ignore = pProperties;
std::ignore = phMem;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}

UR_APIEXPORT ur_result_t UR_APICALL urMemGetInfo(ur_mem_handle_t hMemory,
Expand All @@ -156,7 +156,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urMemGetInfo(ur_mem_handle_t hMemory,
std::ignore = pPropValue;
std::ignore = pPropSizeRet;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}

UR_APIEXPORT ur_result_t UR_APICALL urMemImageGetInfo(ur_mem_handle_t hMemory,
Expand All @@ -170,5 +170,5 @@ UR_APIEXPORT ur_result_t UR_APICALL urMemImageGetInfo(ur_mem_handle_t hMemory,
std::ignore = pPropValue;
std::ignore = pPropSizeRet;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}
14 changes: 7 additions & 7 deletions unified-runtime/source/adapters/native_cpu/program.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ urProgramCreateWithIL(ur_context_handle_t hContext, const void *pIL,
std::ignore = pProperties;
std::ignore = phProgram;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}

static ur_result_t
Expand Down Expand Up @@ -206,7 +206,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urProgramGetFunctionPointer(
std::ignore = pFunctionName;
std::ignore = ppFunctionPointer;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}

UR_APIEXPORT ur_result_t UR_APICALL urProgramGetGlobalVariablePointer(
Expand All @@ -218,7 +218,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urProgramGetGlobalVariablePointer(
std::ignore = pGlobalVariableSizeRet;
std::ignore = ppGlobalVariablePointerRet;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}

UR_APIEXPORT ur_result_t UR_APICALL
Expand Down Expand Up @@ -264,7 +264,7 @@ urProgramGetBuildInfo(ur_program_handle_t hProgram, ur_device_handle_t hDevice,
std::ignore = pPropValue;
std::ignore = pPropSizeRet;

CONTINUE_NO_IMPLEMENTATION
CONTINUE_NO_IMPLEMENTATION;
}

UR_APIEXPORT ur_result_t UR_APICALL urProgramSetSpecializationConstants(
Expand All @@ -274,15 +274,15 @@ UR_APIEXPORT ur_result_t UR_APICALL urProgramSetSpecializationConstants(
std::ignore = count;
std::ignore = pSpecConstants;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}

UR_APIEXPORT ur_result_t UR_APICALL urProgramGetNativeHandle(
ur_program_handle_t hProgram, ur_native_handle_t *phNativeProgram) {
std::ignore = hProgram;
std::ignore = phNativeProgram;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}

UR_APIEXPORT ur_result_t UR_APICALL urProgramCreateWithNativeHandle(
Expand All @@ -294,5 +294,5 @@ UR_APIEXPORT ur_result_t UR_APICALL urProgramCreateWithNativeHandle(
std::ignore = pProperties;
std::ignore = phProgram;

DIE_NO_IMPLEMENTATION
DIE_NO_IMPLEMENTATION;
}