Skip to content

[SYCL][NFC] Replace a macro with a lambda in LowerWGScope.cpp #17564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

[SYCL][NFC] Replace a macro with a lambda in LowerWGScope.cpp #17564

merged 1 commit into from
Mar 21, 2025

Conversation

Maetveis
Copy link
Contributor

There's no good reason to use a macro here, a lambda is simpler and easier to modify.

@Maetveis
[SYCL][NFC] Replace a macro with a lambda in LowerWGScope.cpp
a1c7aec 
There's no good reason to use a macro here, a lambda is simpler and
easier to modify.
@Maetveis Maetveis requested a review from a team as a code owner March 21, 2025 08:10
maarquitos14
maarquitos14 approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sarnex sarnex merged commit e6ad733 into intel:sycl Mar 21, 2025
22 checks passed
@Maetveis Maetveis deleted the nfc-replace-macro-with-lambda branch March 21, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarnex sarnex sarnex approved these changes

@maarquitos14 maarquitos14 maarquitos14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Maetveis @sarnex @maarquitos14