Skip to content

[SYCL] Resolve build failure in SYCLPostLink component in shared libs mode #17573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

maksimsab
Copy link
Contributor

This change resolve a build issue that was introduced in #17454.

This change resolve a build issue that was introduced in intel#17454
@maksimsab maksimsab requested a review from a team as a code owner March 21, 2025 13:50
@maksimsab
Copy link
Contributor Author

maksimsab commented Mar 21, 2025

I am running the full local testing right now.

UPD: it has successfully completed.

Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Think we might want to start doing pre-commit local builds with --shared-libs for these.

Thanks

@maksimsab maksimsab changed the title [SYCL] Resolve build failure in SYCLPostLink component in shared libs. mode [SYCL] Resolve build failure in SYCLPostLink component in shared libs mode Mar 21, 2025
@sarnex
Copy link
Contributor

sarnex commented Mar 21, 2025

Build passed so merging

@sarnex sarnex merged commit 1387710 into intel:sycl Mar 21, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants