[SYCL][Doc] Add test plan for sycl_ext_intel_kernel_queries extension #17593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
againull
reviewed
Mar 25, 2025
|
|
||
| ## Tests | ||
|
|
||
| ### Unit tests |
There was a problem hiding this comment.
Sorry for delayed review. Test plan indicates that unit tests are going to be added (i.e. https://github.com/intel/llvm/tree/sycl/sycl/unittests) but corresponding PR - #17594 - actually adds e2e lit test, not a unit test.
So, please change the wording in the test plan.
There was a problem hiding this comment.
I recently discovered that that test won't be of any use. And if I add the requirement on the aspect the test would be actually dropped. I'll try to add a unittest this week that'd use mock ur.
There was a problem hiding this comment.
That sounds good, in that case this test plan looks good, but should it be moved to unittests directory?
againull
approved these changes
Mar 26, 2025
againull
pushed a commit
that referenced
this pull request
Mar 26, 2025
This adds a unittest for the kernel queries extension according to #17593.
KornevNikita
pushed a commit
that referenced
this pull request
Jun 3, 2025
This adds a unittest for the kernel queries extension according to #17593.
KornevNikita
pushed a commit
to KornevNikita/llvm
that referenced
this pull request
Jun 10, 2025
This adds a unittest for the kernel queries extension according to intel#17593.
AlexeySachkov
pushed a commit
that referenced
this pull request
Jun 12, 2025
Cherry-pick commits that reached the internal branch between intel/llvm cutoff and release branch pulldown. Patches included: [SYCL][E2E] Fix DeviceLib/assert-windows.cpp run-time errors (#17493) Patch-by: David Garcia Orozco <[email protected]> --- [SYCL] Fix memory leak. (#17632) According to https://github.com/llvm/llvm-project/blob/main/llvm/unittests/Demangle/OutputBufferTest.cpp, `OutputBuffer` has to be manually freed. Patch-by: Marcos Maronas <[email protected]> --- [SYCL][E2E][Matrix] Cleanup of xfail and unsupported (#17688) Patch-by: Dounia Khaldi <[email protected]> --- [SYCL][E2E][Matrix] Restrict XFAIL in some tests to DG2 (#17639) XPASSing in [nightly](https://github.com/intel/llvm/actions/runs/14050841978) but failing in pre/postcommit, make them XFAIL only where they actually fail. Patch-by: Nick Sarnie <[email protected]> --- [SYCL][ESIMD] Move RAII deleter init after buffer allocation. (#17706) The buffer seems to be allocated in the call to `NameNode->print(NameBuf)`, so we need to move the RAII deleter after that call, otherwise the buffer keeps leaking because when the RAII deleter is created, there's no buffer yet. Patch-by: Marcos Maronas <[email protected]> --- [SYCL] Add spill_memory_size unittest (#17657) This adds a unittest for the kernel queries extension according to #17593. Patch-by: Petr Kurapov <[email protected]> --- [SYCL][Bindless][E2E] Add 1D host USM tests (#17374) Adds 1D Host USM backed image tests. This patch also fixes device aspect queries for 1D & 2D USM backed image sampling support. Patch-by: przemektmalon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the test plan for sycl_ext_intel_kernel_queries extension.