Skip to content

Implement the sycl_khr_group_interface extension #17595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
270 changes: 270 additions & 0 deletions sycl/include/sycl/khr/group_interface.hpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,270 @@
//==----- group_interface.hpp --- sycl_khr_group_interface extension -------==//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#pragma once

#include <sycl/ext/oneapi/free_function_queries.hpp>
#include <sycl/id.hpp>
#include <sycl/range.hpp>

#ifdef __DPCPP_ENABLE_UNFINISHED_KHR_EXTENSIONS
#define SYCL_KHR_GROUP_INTERFACE 1
#endif

#if __cplusplus >= 202302L && defined(__has_include)
#if __has_include(<mdspan>)
#include <mdspan>
#endif
#endif

namespace sycl {
inline namespace _V1 {
#ifdef __DPCPP_ENABLE_UNFINISHED_KHR_EXTENSIONS
namespace khr {

// Forward declarations for traits.
template <int Dimensions> class work_group;
class sub_group;
template <typename ParentGroup> class member_item;

} // namespace khr

namespace detail {
#if defined(__cpp_lib_mdspan)
template <typename IndexType, int Dimensions> struct single_extents;

template <typename IndexType> struct single_extents<IndexType, 1> {
using type = std::extents<IndexType, 1>;
};

template <typename IndexType> struct single_extents<IndexType, 2> {
using type = std::extents<IndexType, 1, 1>;
};

template <typename IndexType> struct single_extents<IndexType, 3> {
using type = std::extents<IndexType, 1, 1, 1>;
};
#endif

template <typename T> struct is_khr_group : public std::false_type {};

template <int Dimensions>
struct is_khr_group<khr::work_group<Dimensions>> : public std::true_type {};

template <> struct is_khr_group<khr::sub_group> : public std::true_type {};

} // namespace detail

namespace khr {

// Forward declaration for friend function.
template <typename ParentGroup>
std::enable_if_t<detail::is_khr_group<ParentGroup>::value,
member_item<ParentGroup>>
get_member_item(ParentGroup g) noexcept;

template <int Dimensions = 1> class work_group {
public:
using id_type = sycl::id<Dimensions>;
using linear_id_type = size_t;
using range_type = sycl::range<Dimensions>;
#if defined(__cpp_lib_mdspan)
using extents_type = std::dextents<size_t, Dimensions>;
#endif
using size_type = size_t;
static constexpr int dimensions = Dimensions;
static constexpr memory_scope fence_scope = memory_scope::work_group;

work_group(group<Dimensions>) noexcept {}

operator group<Dimensions>() const noexcept { return legacy(); }

id_type id() const noexcept { return legacy().get_group_id(); }

linear_id_type linear_id() const noexcept {
return legacy().get_group_linear_id();
}

range_type range() const noexcept { return legacy().get_group_range(); }

#if defined(__cpp_lib_mdspan)
constexpr extents_type extents() const noexcept {
auto LocalRange = legacy().get_local_range();
if constexpr (dimensions == 1) {
return extents_type(LocalRange[0]);
} else if constexpr (dimensions == 2) {
return extents_type(LocalRange[0], LocalRange[1]);
} else if constexpr (dimensions == 3) {
return extents_type(LocalRange[0], LocalRange[1], LocalRange[2]);
}
}

constexpr typename extents_type::index_type
extent(typename extents_type::rank_type r) const noexcept {
return extents().extent(r);
}

static constexpr typename extents_type::rank_type rank() noexcept {
return extents_type::rank();
}

static constexpr typename extents_type::rank_type rank_dynamic() noexcept {
return extents_type::rank_dynamic();
}

static constexpr size_t
static_extent(typename extents_type::rank_type r) noexcept {
return extents_type::static_extent(r);
}
#endif

size_type size() const noexcept { return legacy().get_local_range().size(); }

private:
group<Dimensions> legacy() const noexcept {
return ext::oneapi::this_work_item::get_work_group<Dimensions>();
}
};

class sub_group {
public:
using id_type = sycl::id<1>;
using linear_id_type = uint32_t;
using range_type = sycl::range<1>;
#if defined(__cpp_lib_mdspan)
using extents_type = std::dextents<uint32_t, 1>;
#endif
using size_type = uint32_t;
static constexpr int dimensions = 1;
static constexpr memory_scope fence_scope = memory_scope::sub_group;

sub_group(sycl::sub_group) noexcept {}

operator sycl::sub_group() const noexcept { return legacy(); }

id_type id() const noexcept { return legacy().get_group_id(); }

linear_id_type linear_id() const noexcept {
return legacy().get_group_linear_id();
}

range_type range() const noexcept { return legacy().get_group_range(); }

#if defined(__cpp_lib_mdspan)
extents_type extents() const noexcept {
return extents_type(legacy().get_local_range()[0]);
}

typename extents_type::index_type
extent(typename extents_type::rank_type r) const noexcept {
return extents().extent(r);
}

static constexpr typename extents_type::rank_type rank() noexcept {
return extents_type::rank();
}

static constexpr typename extents_type::rank_type rank_dynamic() noexcept {
return extents_type::rank_dynamic();
}

static constexpr size_t
static_extent(typename extents_type::rank_type r) noexcept {
return extents_type::static_extent(r);
}
#endif

size_type size() const noexcept { return legacy().get_local_range().size(); }

size_type max_size() const noexcept {
return legacy().get_max_local_range().size();
}

private:
sycl::sub_group legacy() const noexcept {
return ext::oneapi::this_work_item::get_sub_group();
}
};

template <typename ParentGroup> class member_item {
public:
using id_type = typename ParentGroup::id_type;
using linear_id_type = typename ParentGroup::linear_id_type;
using range_type = typename ParentGroup::range_type;
#if defined(__cpp_lib_mdspan)
using extents_type = typename detail::single_extents<
typename ParentGroup::extents_type::index_type,
ParentGroup::dimensions>::type;
#endif
using size_type = typename ParentGroup::size_type;
static constexpr int dimensions = ParentGroup::dimensions;
static constexpr memory_scope fence_scope = memory_scope::work_item;

id_type id() const noexcept { return legacy().get_local_id(); }

linear_id_type linear_id() const noexcept {
return legacy().get_local_linear_id();
}

range_type range() const noexcept { return legacy().get_local_range(); }

#if defined(__cpp_lib_mdspan)
constexpr extents_type extents() const noexcept { return extents_type(); }

constexpr typename extents_type::index_type
extent(typename extents_type::rank_type r) const noexcept {
return extents().extent(r);
}

static constexpr typename extents_type::rank_type rank() noexcept {
return extents_type::rank();
}

static constexpr typename extents_type::rank_type rank_dynamic() noexcept {
return extents_type::rank_dynamic();
}

static constexpr size_t
static_extent(typename extents_type::rank_type r) noexcept {
return extents_type::static_extent(r);
}
#endif

constexpr size_type size() const noexcept { return 1; }

private:
auto legacy() const noexcept {
if constexpr (std::is_same_v<ParentGroup, sub_group>) {
return ext::oneapi::this_work_item::get_sub_group();
} else {
return ext::oneapi::this_work_item::get_work_group<
ParentGroup::dimensions>();
}
}

protected:
member_item() {}

friend member_item<ParentGroup>
get_member_item<ParentGroup>(ParentGroup) noexcept;
};

template <typename ParentGroup>
std::enable_if_t<detail::is_khr_group<ParentGroup>::value,
member_item<ParentGroup>>
get_member_item(ParentGroup) noexcept {
return member_item<ParentGroup>{};
}

template <typename Group> bool leader_of(Group g) {
return get_member_item(g).linear_id() == 0;
}

} // namespace khr
#endif
} // namespace _V1
} // namespace sycl
1 change: 1 addition & 0 deletions sycl/include/sycl/sycl.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -123,3 +123,4 @@
#include <sycl/ext/oneapi/virtual_mem/physical_mem.hpp>
#include <sycl/ext/oneapi/virtual_mem/virtual_mem.hpp>
#include <sycl/ext/oneapi/weak_object.hpp>
#include <sycl/khr/group_interface.hpp>
38 changes: 38 additions & 0 deletions sycl/test-e2e/GroupInterface/leader_of.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

#define __DPCPP_ENABLE_UNFINISHED_KHR_EXTENSIONS

#include <cassert>
#include <sycl/detail/core.hpp>
#include <sycl/group_algorithm.hpp>
#include <sycl/khr/group_interface.hpp>

using namespace sycl;

void test(queue q) {
int out = 0;
size_t G = 4;

range<2> R(G, G);
{
buffer<int> out_buf(&out, 1);

q.submit([&](handler &cgh) {
auto out = out_buf.template get_access<access::mode::read_write>(cgh);
cgh.parallel_for(nd_range<2>(R, R), [=](nd_item<2> it) {
khr::work_group<2> g = it.get_group();
if (khr::leader_of(g)) {
out[0] += 1;
}
});
});
}
assert(out == 1);
}

int main() {
queue q;
test(q);
return 0;
}
Loading
Loading