[CI] Introduce placeholder sycl-ur-perf-benchmarking.yml #17611
Conversation
.github/workflows/benchmark.yml
Outdated
| @@ -0,0 +1,12 @@ | |||
| name: Benchmarks | |||
|
|
|||
| # This workflow is a WIP: this workflow file acts as a placeholder. | |||
There was a problem hiding this comment.
Will we be using this file for the unified compute-benchmark workflow? If so, I'd prefer renaming it to sycl-perf-benchmarking or something similar with the sycl- prefix.
There was a problem hiding this comment.
It will be running test suites the UR people wanted as well, that's why I was hesitant on adding a sycl- prefix
...that being said, any better name ideas that don't exclude UR? 😅
There was a problem hiding this comment.
It will be running test suites the UR people wanted as well, that's why I was hesitant on adding a sycl- prefix
sycl-ur-perf-benchmarking? All of our home-grown workflows have sycl or ur prefixes to distinguish them from the workflows in upstream LLVM. That's the naming scheme I want the benchmarking workflow to follow as well.
There was a problem hiding this comment.
I've gone ahead and renamed it, but @pbalcer let me know if you've any opinions on how you want this named
There was a problem hiding this comment.
I don't think we should be distinguishing between sycl and ur in this case. So I'm in favor of just dropping the prefix. Or, if we need one, I'd just stick with sycl-, it's the most general one.
ianayl
changed the title
|
@intel/llvm-gatekeepers PR is ready for merge, thanks! |
|
CI hasn't passed yet, should we wait for it? |
Feel free to if you'd like, but the changes here are practically NFC for all intents and purposes: I don't anticipate anything going wrong here. |
This PR adds a placeholder sycl-ur-perf-benchmarking.yml in preparation for testing and merging the benchmark.yml in #17229.