[UR] Remove UMF_DISABLE_HWLOC flag #17676
Conversation
|
@intel/unified-runtime-reviewers, please review. All tests passed. |
|
Does this change mean that hwloc is a mandatory part of UMF and building without it is no longer supported? |
| @@ -53,7 +53,6 @@ jobs: | |||
| -DCMAKE_BUILD_TYPE=Debug | |||
| -DUR_BUILD_TESTS=OFF | |||
| -DUR_FORMAT_CPP_STYLE=ON | |||
| -DUMF_DISABLE_HWLOC=ON | |||
There was a problem hiding this comment.
Is it not faster to just fetch hwloc via apt-get rather than building it ourself?
There was a problem hiding this comment.
That's a good point, I'll add the package.
Yes, the option for disabling hwloc support in UMF will be removed as it will be a mandatory part of UMF. The user would have to either have hwloc installed or UMF will fetch it. |
This flag will be removed from UMF and the libhwloc-dev library will not be an option but the requirement.
PatKamin
force-pushed
the
remove-disable-hwloc-flag
branch
from
8341005 to
fefcb3c
Compare
|
@intel/dpcpp-devops-reviewers, please review. It seems like the Battlemage workflows failures are unrelated to changes from this PR. |
This flag will be removed from UMF. Either
hwlocinstalled in the system is used or it's fetched if not found.Ref.: #15261