Skip to content

[SYCL] Add vec explicit conversion #17713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

[SYCL] Add vec explicit conversion #17713

merged 1 commit into from
Apr 2, 2025

Conversation

aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner March 28, 2025 16:54
@aelovikov-intel

This comment was marked as outdated.

Sign in to view
@bader

This comment was marked as outdated.

Sign in to view
@aelovikov-intel

This comment was marked as outdated.

Sign in to view
@AaronBallman

This comment was marked as outdated.

Sign in to view
@aelovikov-intel aelovikov-intel force-pushed the vec-explicit-conversion branch from ddd9d04 to 93a3f7f Compare March 28, 2025 20:50
@aelovikov-intel aelovikov-intel mentioned this pull request Mar 28, 2025
Merged
@aelovikov-intel
Copy link
Contributor Author

aelovikov-intel commented Mar 31, 2025 •
edited
Loading

No actual review of the changes has started here, so I'm going to force push. And I liked gerrit's workflow much better than GH's PRs...

@aelovikov-intel aelovikov-intel force-pushed the vec-explicit-conversion branch from 93a3f7f to fe47a12 Compare March 31, 2025 18:36
aelovikov-intel added a commit to aelovikov-intel/llvm that referenced this pull request Mar 31, 2025
@aelovikov-intel
[SYCL] Fix 1-element vec ambiguities
b7edbc3 
KhronosGroup/SYCL-Docs#670

Technically, we also implement part of
KhronosGroup/SYCL-Docs#674 (`std::byte` as
element type) here, but there is no reasonable way to make them
completely independent.

This is built on top of
intel#17712 and
intel#17713.

With these three pieces in place we can keep building CTS successfully,
so enable this new implementation (via `__SYCL_USE_PREVIEW_VEC_IMPL`)
automatically under `-fpreview-breaking-changes` mode.
@aelovikov-intel aelovikov-intel force-pushed the vec-explicit-conversion branch from fe47a12 to bac1108 Compare April 1, 2025 20:10
uditagarwal97
uditagarwal97 approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aelovikov-intel
Copy link
Contributor Author 

2025-04-01T20:44:50.4036277Z [ RUN      ] SchedulerTest.FailedDependency
2025-04-01T20:44:50.4037147Z D:\github\_work\llvm\llvm\src\sycl\unittests\scheduler\CommandsWaitForEvents.cpp(54): error: Value of: (TestContext->EventCtx1 == **params.pphEventWaitList) || (TestContext->EventCtx2 == **params.pphEventWaitList)
2025-04-01T20:44:50.4037244Z   Actual: false
2025-04-01T20:44:50.4037335Z Expected: true
2025-04-01T20:44:50.4037476Z urEventsWait called for unknown event
2025-04-01T20:44:50.4037484Z 
2025-04-01T20:44:50.4037651Z [  FAILED  ] SchedulerTest.FailedDependency (1 ms)

doesn't seem to be related. Copy-pasting it here for future searches.

@aelovikov-intel
Copy link
Contributor Author

Dev IGC infrastructural failures are unrelated and were seen on other PRs too.

@aelovikov-intel aelovikov-intel merged commit 1d0e1eb into intel:sycl Apr 2, 2025
33 of 39 checks passed
@aelovikov-intel aelovikov-intel deleted the vec-explicit-conversion branch April 2, 2025 14:54
aelovikov-intel added a commit that referenced this pull request Apr 2, 2025
@aelovikov-intel
[SYCL] Fix 1-element vec ambiguities (#17722)
436191a 
Implements KhronosGroup/SYCL-Docs#670.

Technically, we also implement part of
KhronosGroup/SYCL-Docs#674
(`std::byte` as element type) here, but there is no reasonable way 
to make them completely independent.

This is built on top of #17712 and
#17713.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uditagarwal97 uditagarwal97 uditagarwal97 approved these changes

@slawekptak slawekptak Awaiting requested review from slawekptak slawekptak is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aelovikov-intel @bader @AaronBallman @uditagarwal97