Skip to content

[CI][CTS] Check if the cts_exclude_filter exists #17715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025

Conversation

KornevNikita
Copy link
Contributor

@KornevNikita KornevNikita commented Mar 28, 2025

Otherwise cat may return 1 and fail the step.

@KornevNikita KornevNikita marked this pull request as ready for review March 28, 2025 18:02
@KornevNikita KornevNikita requested a review from a team as a code owner March 28, 2025 18:02
@@ -67,7 +67,7 @@ runs:
# SYCL_CTS_EXCLUDE_TEST_CATEGORIES - Optional file specifying a list
# of test categories to be excluded from the build.
echo "::group::Excluded test categories"
cat $cts_exclude_filter
[ -f "$cts_exclude_filter" ] && cat "$cts_exclude_filter"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but when could it not exist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for example when we test old branches:) - fresh example https://github.com/intel/llvm/actions/runs/14133470110/job/39601252637

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok

@KornevNikita
Copy link
Contributor Author

@intel/llvm-gatekeepers please merge

@uditagarwal97 uditagarwal97 merged commit 7148778 into sycl Mar 31, 2025
20 of 23 checks passed
@uditagarwal97 uditagarwal97 deleted the upd-cts-check-filters branch March 31, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants