[AsyncAlloc][CUDA] Don't set pool maxSize if CUDA version < 12.2 #17733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CUDA did not introduce the maxSize property to CUmemPoolProps until version 12.2. In the case where the user has set a maxSize > 0, and their CUDA version is < 12.2, return an error. This commit fixes the compilation error associated with setting this property in older CUDA versions. Also fix incorrect error reporting when creating a memory pool.
jchlanda
approved these changes
Mar 31, 2025
|
@intel/llvm-gatekeepers can we merge this please. Thanks! |
KornevNikita
pushed a commit
that referenced
this pull request
May 28, 2025
) CUDA did not introduce the maxSize property to CUmemPoolProps until version 12.2. In the case where the user has set a maxSize > 0, and their CUDA version is < 12.2, return an error. This commit fixes the compilation error associated with setting this property in older CUDA versions. Also fix incorrect error reporting when creating a memory pool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUDA did not introduce the maxSize property to CUmemPoolProps until version 12.2. In the case where the user has set a maxSize > 0, and their CUDA version is < 12.2, return an error.
This commit fixes the compilation error associated with setting this property in older CUDA versions.
Also fix incorrect error reporting when creating a memory pool.