[SYCL][COMPAT] Add dummy template params to memory APIs to delay kernel instantiation #17743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`syclcompat::detail::fill` and `syclcompat::detail::memcpy` define SYCL kernels. Any translation unit including the syclcompat/memory.hpp or util.hpp will contain these kernels, as DPC++'s 2-pass compiler is not currently able to reason about which kernels are actually used. Adding a dummy template parameter (typename T = void) ensures that these functions (and thus their kernels) are only instantiated if used.
GeorgeWeb
approved these changes
Apr 2, 2025
|
@intel/llvm-gatekeepers I believe this is ready to merge 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions
syclcompat::detail::fillandsyclcompat::detail::memcpydefine SYCL kernels. Any translation unit including thememory.hpporutil.hppheaders will contain these kernels, as DPC++'s 2-pass compiler is not currently able to reason about which kernels are actually used.Adding a dummy template parameter (typename T = void) ensures that these functions (and thus their kernels) are only instantiated if used.