[SYCL] Fix KernelNameInfo generated for empty template paramter pack #1775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
name type is a template specialization class with empty template pack argument. This commit fixes a bug introduced by commit e7020a1 where an extra comma was printed before empty pack arguments Signed-off-by: Elizabeth Andrews <[email protected]>
|
I think failing test is flakey. I was unable to reproduce it locally. I will rebuild tests to confirm |
erichkeane
reviewed
May 28, 2020
|
Please add [SYCL] tag to commit message when change is SYCL-related. |
elizabethandrews
changed the title
1. Moved Comma Handling back to printArguments() 2. Add a check for empty pack argument in printArguments() Signed-off-by: Elizabeth Andrews <[email protected]>
Fznamznon
approved these changes
May 29, 2020
erichkeane
approved these changes
May 29, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Jun 2, 2020
* upstream/sycl: [SYCL] Handle KernelName templated using type with enum template argument (intel#1780) [SYCL] Fix KernelNameInfo generated for empty template parameter pack (intel#1775) [SYCL] Do not export utility methods from SYCLMemObjT (intel#1768) [Driver][SYCL] Fix processing when using -fsycl-link (intel#1765) [SYCL][NFC] Remove outdated confusing comment (intel#1779) [SYCL][NFC] Wrap classes in .cpp into a namespace to disable external linkage. (intel#1776) [SYCL][CUDA] Fixes CUDA unit tests that uses SYCL directly (intel#1763) [SYCL][Doc] Fix default device selection rules doc (intel#1769) [SYCL][CUDA] Remove pi Event Callback implementation (intel#1735) [SYCL] Throw exception if range/offset of kernel execution exceeds INT_MAX (intel#1713) [SYCL-PTX] Add intermediate layer to libclc to ease type management (intel#1712)
bb-sycl
pushed a commit
that referenced
this pull request
Feb 1, 2023
The main improvement is to enable intrinsics with more complex typing rules to be described. For example, memcpy's requirement that its two pointer arguments have the same type. There is still a larger rewrite of the type scavenger to use TypedPointerType coming down the line. However, this rewrite also needs opaque types to represent the deferred type concept, which is why it hasn't been done yet. This is an intermediate step in the rewrite which better supports some of the other intrinsics with current issues. Original commit: KhronosGroup/SPIRV-LLVM-Translator@df51179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix KernelNameInfo generated in integration header when kernelname type is a template specialization class with empty template pack argument.
This commit fixes a bug introduced by commit e7020a1 where an extra comma was printed before empty pack arguments
Signed-off-by: Elizabeth Andrews [email protected]