[SYCL] Return shared_ptr<platform_impl> by ref #17750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Change the return type of getPlatformImpl() to a reference in the context_impl and device_impl classes.
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
approved these changes
Apr 1, 2025
|
@slawekptak CI results are quite old. Can you please rebase and re-run the CI? |
|
@intel/llvm-gatekeepers this is ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the return type of getPlatformImpl() to a reference in the context_impl and device_impl classes.