Skip to content

[SYCL] Fix traceKernel function to avoid temporary string creation #17868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

vinser52
Copy link
Contributor

@vinser52 vinser52 commented Apr 4, 2025

When the traceKernel function is called with a C-string as a parameter, a temporary std::string object is created. This PR change the traceKernel function to accept std::string_view instead const std::string &.

@vinser52 vinser52 requested a review from a team as a code owner April 4, 2025 18:02
@vinser52 vinser52 requested a review from aelovikov-intel April 4, 2025 18:02
@vinser52 vinser52 changed the title Fix traceKernel function to avoid temporary string creation [SYCL] Fix traceKernel function to avoid temporary string creation Apr 4, 2025
@aelovikov-intel aelovikov-intel changed the title [SYCL] Fix traceKernel function to avoid temporary string creation [SYCL] Fix traceKernel function to avoid temporary string creation Apr 4, 2025
@vinser52 vinser52 requested a review from sergey-semenov April 7, 2025 10:34
@sergey-semenov sergey-semenov merged commit d221298 into intel:sycl Apr 7, 2025
51 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants