[UR] urPlatformGet() takes only 1 adapter. #17876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacault
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
isaacault
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
isaacault
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
approved these changes
Apr 7, 2025
hvdijk
approved these changes
Apr 7, 2025
RossBrunton
reviewed
Apr 8, 2025
npmiller
approved these changes
Apr 8, 2025
RossBrunton
approved these changes
Apr 9, 2025
|
@intel/unified-runtime-reviewers-level-zero Friendly ping. |
pbalcer
approved these changes
Apr 10, 2025
|
@intel/llvm-gatekeepers Please merge. |
igchor
added a commit
to igchor/compute-benchmarks
that referenced
this pull request
Apr 11, 2025
After API change: intel/llvm#17876 Signed-off-by: Igor Chorazewicz <[email protected]>
VPG-SWE-Github
pushed a commit
to intel/compute-benchmarks
that referenced
this pull request
Apr 11, 2025
urPlatformGet API changed in intel/llvm#17876 Signed-off-by: Piotr Balcer <[email protected]>
pbalcer
added a commit
to pbalcer/llvm
that referenced
this pull request
Apr 14, 2025
This fixes a regression after intel#17876
martygrant
pushed a commit
that referenced
this pull request
Apr 14, 2025
This fixes a regression after #17876
Maetveis
reviewed
Apr 15, 2025
Comment on lines
+72
to
+80
| platforms.reserve(platformCount + adapterPlatformCount); | ||
| urPlatformGet(adapter, adapterPlatformCount, &platforms[platformCount], | ||
| &adapterPlatformCount); | ||
| platformCount += adapterPlatformCount; | ||
| } | ||
| if (!platformCount) { | ||
| throw std::runtime_error("No platforms available."); | ||
| } | ||
| platforms.resize(platformCount); |
There was a problem hiding this comment.
This is UB, the access to platforms[platformCount] is out of bounds, because platforms.size() is always 0 here. This should be using resize() and not reserve().
In practice the later .resize() will reset all platforms to nullptr and make the example crash. See #18032
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Apr 15, 2025
Change intel#17876 introduced a regression due to how platforms were generated in examples and tests. This fixes those issues. A fix for the no_platforms test is also included; which was failing due to `UR_ADAPTERS_FORCE_LOAD=""` being treated as absent. Closes intel#18032
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17504 .