Skip to content

[DeviceASAN] Fix multiple contexts in memory overhead statistics #17897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

[DeviceASAN] Fix multiple contexts in memory overhead statistics #17897

merged 2 commits into from
Apr 10, 2025

Conversation

AllanZyne
Copy link
Contributor

@AllanZyne AllanZyne commented Apr 8, 2025 •
edited
Loading

  • Create the internal context in "ShadowMemory" constructor
  • Remove "static" in "ShadowMemory::Setup" and "ShadowMemory::Destroy", because AsanInterceptor::getOrCreateShadowMemory is single thread

@AllanZyne AllanZyne requested review from a team as code owners April 8, 2025 07:12
@AllanZyne AllanZyne changed the title [DeviceASAN] Fix memory overhead statistics [DeviceASAN] Fix multiple contexts in memory overhead statistics Apr 8, 2025
@AllanZyne
Copy link
Contributor Author

@intel/llvm-gatekeepers, please merge

@uditagarwal97
Copy link
Contributor

@intel/llvm-gatekeepers, please merge

Waiting on code owner review from @intel/dpcpp-sanitizers-review.

@AllanZyne
Copy link
Contributor Author

@intel/llvm-gatekeepers, please merge

Waiting on code owner review from @intel/dpcpp-sanitizers-review.

Sorry, I have pinged him to review

@uditagarwal97 uditagarwal97 merged commit ac89277 into sycl Apr 10, 2025
33 checks passed
@bader bader deleted the review/yang/fix_asan_stats branch April 10, 2025 23:38
KornevNikita pushed a commit that referenced this pull request May 27, 2025
@AllanZyne @KornevNikita
[DeviceASAN] Fix multiple contexts in memory overhead statistics (#17897
7fedc6c 
)

- Create the internal context in "ShadowMemory" constructor
- Remove "static" in "ShadowMemory::Setup" and "ShadowMemory::Destroy",
because `AsanInterceptor::getOrCreateShadowMemory` is single thread
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbalcer pbalcer pbalcer approved these changes

@zhaomaosu zhaomaosu zhaomaosu approved these changes

@yingcong-wu yingcong-wu yingcong-wu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AllanZyne @uditagarwal97 @pbalcer @zhaomaosu @yingcong-wu