Skip to content

[SYCL][CUDA] Use piclProgramCreateWithBinary with CUDA backend #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

przemektmalon
Copy link
Contributor

This commit restructures the CUDA backend so that the program manager
calls "piclProgramCreateWithBinary" for both OpenCL and CUDA backends
instead of branching unnecessarily. Unit tests are also updated
accordingly.

Signed-off-by: Przemek Malon [email protected]

@przemektmalon przemektmalon requested review from kbobrovs and a team as code owners June 1, 2020 08:47
@przemektmalon przemektmalon requested a review from romanovvlad June 1, 2020 08:47
@przemektmalon przemektmalon force-pushed the przemek/cuda-program-from-binary branch from 2a25468 to f08a69e Compare June 1, 2020 09:00
@Ruyk Ruyk added the cuda CUDA back-end label Jun 1, 2020
romanovvlad
romanovvlad previously approved these changes Jun 2, 2020
Copy link
Contributor

@romanovvlad romanovvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader
Copy link
Contributor

bader commented Jun 8, 2020

@przemektmalon, please, resolve conflicts.
@kbobrovs, please, review.

This commit restructures the CUDA backend so that the program manager
calls "piclProgramCreateWithBinary" for both OpenCL and CUDA backends
instead of branching unnecessarily. Unit tests are also updated
accordingly.

Signed-off-by: Przemek Malon <[email protected]>
@bader
Copy link
Contributor

bader commented Jun 11, 2020

Merging to unblock #1865.
@kbobrovs, let us know if you have any comments, we'll apply them in separate PR.

@bader bader merged commit 73fb605 into intel:sycl Jun 11, 2020
@przemektmalon przemektmalon deleted the przemek/cuda-program-from-binary branch June 22, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda CUDA back-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants