[SYCL] Fix ProgramManager::kernelUsesAssert to avoid tmp string creation
#17912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinser52
changed the title
ProgramManager::kernelUsesAssert to avoid tmp string creationProgramManager::kernelUsesAssert to avoid tmp string creation
steffenlarsen
approved these changes
Apr 9, 2025
| // different types without temporary key_type object creation. This includes | ||
| // standard overloads, such as comparison between std::string and | ||
| // std::string_view or just char*. | ||
| using KernelUsesAssertSet = std::set<std::string, std::less<>>; |
There was a problem hiding this comment.
Nit; This alias feels a little overkill when it's just used here and in a unittest.
There was a problem hiding this comment.
So it is a common practice in C++ to use aliases for container types. As you pointed out, there are already two places. If we decide to change the container type in the future it is easier with alias.
|
@steffenlarsen should we merge this PR? |
sergey-semenov
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handler calls the
ProgramManager::kernelUsesAssertwithconst char *argument. It resulted in a temporarystd::stringcreation. This PR changes theProgramManager::kernelUsesAssertto accept template parameter and uses heterogeneous lookup feature ofstd::set