Skip to content

[SYCL] Fix a warning after https://github.com/intel/llvm/pull/17838 #17920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

[SYCL] Fix a warning after https://github.com/intel/llvm/pull/17838 #17920

merged 1 commit into from
Apr 9, 2025

Conversation

aelovikov-intel
Copy link
Contributor

No description provided.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner April 8, 2025 22:32
@aelovikov-intel
Copy link
Contributor Author

I'm not sure under what conditions it can be reproduced, was reported by @jbrodman. However, just use the "normal" !std::is_same_v<T, T> trick instead of being "smart" and trying to benefit off having a value template param.

@aelovikov-intel
Copy link
Contributor Author

I believe timed-out tests are unrelated.

@aelovikov-intel aelovikov-intel merged commit 7a35089 into intel:sycl Apr 9, 2025
22 of 24 checks passed
@aelovikov-intel aelovikov-intel deleted the fix-warning branch April 9, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uditagarwal97 uditagarwal97 uditagarwal97 approved these changes

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov sergey-semenov is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aelovikov-intel @uditagarwal97