[UR] [L0 v2] Add mutable commands to command buffer #17925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igchor
reviewed
Apr 9, 2025
unified-runtime/source/adapters/level_zero/helpers/mutable_helpers.cpp
Outdated
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/v2/command_list_cache.hpp
Outdated
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/v2/command_list_cache.hpp
Outdated
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/v2/command_buffer.cpp
Outdated
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/v2/command_buffer.cpp
Outdated
Show resolved
Hide resolved
fabiomestre
reviewed
Apr 10, 2025
unified-runtime/source/adapters/level_zero/v2/command_buffer.cpp
Outdated
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/v2/command_buffer.cpp
Outdated
Show resolved
Hide resolved
EwanC
reviewed
Apr 11, 2025
unified-runtime/source/adapters/level_zero/helpers/mutable_helpers.cpp
Outdated
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/helpers/mutable_helpers.hpp
Outdated
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/v2/command_buffer.cpp
Outdated
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/v2/command_buffer.hpp
Outdated
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/v2/command_list_cache.cpp
Outdated
Show resolved
Hide resolved
igchor
reviewed
Apr 11, 2025
EwanC
reviewed
Apr 14, 2025
unified-runtime/source/adapters/level_zero/v2/command_list_cache.cpp
Outdated
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/v2/command_list_cache.cpp
Outdated
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/v2/command_buffer.hpp
Outdated
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/v2/command_buffer.cpp
Outdated
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/v2/command_buffer.cpp
Outdated
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/v2/command_buffer.cpp
Outdated
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/v2/command_buffer.cpp
Outdated
Show resolved
Hide resolved
Xewar313
force-pushed
the
add-mutable-commands
branch
from
3a77996 to
b07861c
Compare
Xewar313
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Xewar313
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Xewar313
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Xewar313
force-pushed
the
add-mutable-commands
branch
from
51d23ba to
9fb3ca7
Compare
Xewar313
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
@EwanC I re-checked all tests, and you were right - the |
EwanC
approved these changes
May 9, 2025
There was a problem hiding this comment.
@EwanC I re-checked all tests, and you were right - the
test-e2e/Graph/Update/dyn_cgf_update_before_finalize.cppfailed because of unnecessary check in the code - it is fixed now. However, the rest of thesycl/test-e2e/Graph/Updatetests (and most of allsycl/test-e2e/Graph/Update) fail due to driver bug.
Cool, if you've been able to run the tests and triage the fails as being due to the driver sync bug, then i'm happy with that. We can do anything else as a follow up, this is a large PR so should try get it in.
|
The failure on CI is known (#18349), @intel/llvm-gatekeepers please merge. |
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Jun 9, 2025
The Level-Zero V2 has had support for graph update since intel#17925
kbenzie
pushed a commit
that referenced
this pull request
Jun 9, 2025
The Level-Zero V2 has had support for graph update since #17925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.