[AsyncAlloc][SYCL][ABI-BREAK] Use the SYCL properties extension for memory pool creation #17955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seanst98
force-pushed
the
sean/async-alloc-properties-ext
branch
from
dcb5523 to
8712e9f
Compare
…emory pool creation Introduce initial_threshold, maximum_size, read_only, and zero_init runtime properties conforming to the SYCL properties extension, and apply these properties to the creation of memory pools.
|
We are not allowed to break ABI outside of the window, is it possible to guard the breaking changes with __INTEL_PREVIEW_BREAKING_CHANGES macro? |
againull
added
the
abi-break
omarahmed1111
force-pushed
the
sean/async-alloc-properties-ext
branch
from
8712e9f to
b615655
Compare
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
omarahmed1111
force-pushed
the
sean/async-alloc-properties-ext
branch
from
b615655 to
6171ed8
Compare
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
omarahmed1111
force-pushed
the
sean/async-alloc-properties-ext
branch
from
6171ed8 to
599af2f
Compare
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
omarahmed1111
force-pushed
the
sean/async-alloc-properties-ext
branch
from
599af2f to
b0e7b06
Compare
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
omarahmed1111
force-pushed
the
sean/async-alloc-properties-ext
branch
from
7cd8ba7 to
5d77b23
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@omarahmed1111 @Seanst98 I'm very sorry, I completely missed that this is an experimental extension which has been just recently implemented (so, as far as I understand it hasn't even made it to the previous release). For experimental extensions it is allowed to break ABI, so initial version of the PR was good (i.e. there is no necessity to guard with __INTEL_PREVIEW_BREAKING_CHANGES). Again, really sorry for false alarm |
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
omarahmed1111
force-pushed
the
sean/async-alloc-properties-ext
branch
from
b79af62 to
2b43de3
Compare
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
force-pushed
the
sean/async-alloc-properties-ext
branch
from
2b43de3 to
19971e8
Compare
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
konradkusiak97
approved these changes
Jun 16, 2025
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
force-pushed
the
sean/async-alloc-properties-ext
branch
from
05164ff to
f9761f8
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce initial_threshold, maximum_size, read_only, and zero_init runtime properties conforming to the SYCL properties extension, and apply these properties to the creation of memory pools.
This PR is a draft until the feature has been added to the sycl_ext_oneapi_async_memory_alloc spec.