Skip to content

[SYCL] Use urGetDeviceInfo to check bfloat16 native conversion extension #18023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2025

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Apr 15, 2025

As agreement in #16729 , In general we discourage the use of the extension strings as it is a remnant of the OpenCL days. Instead we want to use urDeviceGetInfo when possible. This is a follow-up pr to replace checking OpenCL extension string with urGetDeviceInfo for native bfloat16 conversion extension.

@jinge90 jinge90 requested a review from a team as a code owner April 15, 2025 06:33
@jinge90 jinge90 requested a review from maarquitos14 April 15, 2025 06:33
@jinge90 jinge90 requested a review from steffenlarsen April 15, 2025 06:33
@jinge90
Copy link
Contributor Author

jinge90 commented Apr 15, 2025

Hi, @steffenlarsen
Could you take a look at this PR? This a a follow-up pr to address your previous comments.
Thanks very much.

@jinge90 jinge90 requested a review from steffenlarsen April 16, 2025 05:13
@jinge90 jinge90 marked this pull request as draft April 16, 2025 05:45
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jinge90
Copy link
Contributor Author

jinge90 commented Apr 16, 2025

Hi, @steffenlarsen
This PR has a bug, I will update it soon, please don't merge it.
Thanks very much.

@jinge90 jinge90 marked this pull request as ready for review April 16, 2025 06:42
Signed-off-by: jinge90 <[email protected]>
@jinge90 jinge90 requested a review from a team April 16, 2025 07:56
@jinge90
Copy link
Contributor Author

jinge90 commented Apr 16, 2025

Hi, @intel/llvm-gatekeepers
Could you help merge this PR?
Thanks very much.

@martygrant martygrant merged commit 8f2510f into intel:sycl Apr 16, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants