[UR] Fixes for using ONEAPI_DEVICE_SELECTOR with linear ids
#18029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Linear IDs (the `0` in `opencl:0`) did not function as intended when there was multiple platforms; each platform started counting at zero. This patch changes it so that they start counting at an appropriate number that should match `urinfo`. `urinfo` itself has also been updated to not display linear IDs when the device list is being filtered, as they will not be correct. This matches the behavior of sycl-ls and is different to the `--no-linear-ids` which changes the format of the output.
RossBrunton
force-pushed
the
ross/odsfix
branch
from
025d4ff to
d75dbf1
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
approved these changes
Apr 16, 2025
|
@intel/llvm-gatekeepers Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear IDs (the
0inopencl:0) did not function as intended whenthere was multiple platforms; each platform started counting at zero.
This patch changes it so that they start counting at an appropriate
number that should match
urinfo.urinfoitself has also been updated to not display linear IDs whenthe device list is being filtered, as they will not be correct. This
matches the behavior of sycl-ls and is different to the
--no-linear-idswhich changes the format of the output.