[SYCL] Avoid datarace when waiting on the same event in multiple threads #1803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnmokhov
requested review from
rbegam and
dm-vodopyanov
and removed request for
rbegam
romanovvlad
requested changes
Jun 2, 2020
s-kanaev
reviewed
Jun 2, 2020
One thread could acquire shared access in `waitForEvent` after another thread executed `cleanupFinishedCommands` (which has exclusive access). This resulted in "Event has no associated command?" assertion failure in `GraphProcessor::waitForEvent`. Signed-off-by: Dmitri Mokhov <[email protected]>
romanovvlad
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thread could acquire shared access in
waitForEventafter anotherthread executed
cleanupFinishedCommands(which has exclusive access).This resulted in "Event has no associated command?" assertion failure
in
GraphProcessor::waitForEvent.Signed-off-by: Dmitri Mokhov [email protected]