[UR] For non-standalone builds, use built DPCXX/Extractor #18062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
If we are not a standalone build (that is, we are built as part of intel/llvm) and `UR_DPCXX` is not specified as part of the cmake options, we use the `clang` built by `intel/llvm` to generate device binaries. Likewise, if no `UR_DEVICE_CODE_EXTRACTOR` is specified and we are not standalone, the `clang-offload-extractor` from intel/llvm is used. This change should not affect CI, but does mean that the UR testing targets can be built in an intel/llvm local build.
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-reviewers-cuda @intel/unified-runtime-reviewers-level-zero Small change for these backends; I've added |
npmiller
approved these changes
Apr 23, 2025
pbalcer
approved these changes
Apr 23, 2025
martygrant
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are not a standalone build (that is, we are built as part of
intel/llvm) and
UR_DPCXXis not specified as part of the cmakeoptions, we use the
clangbuilt byintel/llvmto generate devicebinaries.
Likewise, if no
UR_DEVICE_CODE_EXTRACTORis specified and we arenot standalone, the
clang-offload-extractorfrom intel/llvm is used.This change should not affect CI, but does mean that the UR testing
targets can be built in an intel/llvm local build.